fix: requires auth to forward auth handler (AuthVerify config) #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethklee
changed the title
itzg
approved these changes
Jul 2, 2025
|
Now that I see #109 I remember why it used to done in the original code. I think it's going to turn out that these two behaviors need to be a configurable choice. |
|
@kennethklee can you also review the latest changes in https://github.com/itzg/saml-auth-proxy/pull/109/files |
|
makes sense. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
The forward auth endpoint correctly returns 2xx status code for authenticated requests. However, it returns 401 instead of triggering login from saml.
Changes: