fix: override eth_getProof to enable withdrawals
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
changed the title
eth_getProof to enable withdrawalseth_getProof to enable withdrawals
mattsse
reviewed
Nov 26, 2024
|
|
||
| // If we are targeting the withdrawal contract, then we only need to provide the storage | ||
| // proofs for withdrawal. | ||
| if address == WITHDRAWAL_CONTRACT { |
Member
There was a problem hiding this comment.
is this something we want to bake into op-reth as well?
onbjerg
reviewed
Nov 26, 2024
Contributor
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
I'd also like an e2e test, one for proving the withdrawal contract, one for proving something that isn't the withdrawal contract (to ensure the fallback works through refactors e.g.)
can take a look at our current e2e tests
Merged
joshieDo
force-pushed
the
joshie/override
branch
from
9027de2 to
0dafa42
Compare
onbjerg
approved these changes
Nov 26, 2024
Contributor
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
looks good to me, great work bud
onbjerg
pushed a commit
that referenced
this pull request
Nov 26, 2024
introduces [StorageRootProvider::storage_multiproof](paradigmxyz/reth#12879) that can be used on #97
0xtinkle
pushed a commit
to 0xtinkle/traverse
that referenced
this pull request
Apr 3, 2025
introduces [StorageRootProvider::storage_multiproof](paradigmxyz/reth#12879) that can be used on ithacaxyz/odyssey#97
0xtinkle
added a commit
to 0xtinkle/traverse
that referenced
this pull request
Apr 3, 2025
introduces [StorageRootProvider::storage_multiproof](paradigmxyz/reth#12879) that can be used on ithacaxyz/odyssey#97
0xtinkle
added a commit
to 0xtinkle/traverse
that referenced
this pull request
Apr 3, 2025
introduces [StorageRootProvider::storage_multiproof](paradigmxyz/reth#12879) that can be used on ithacaxyz/odyssey#97
mev-smithxbg
added a commit
to mev-smithxbg/odyssey
that referenced
this pull request
Sep 28, 2025
introduces [StorageRootProvider::storage_multiproof](paradigmxyz/reth#12879) that can be used on ithacaxyz/odyssey#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84 and closes #72
Overrides
eth_getProofas to enable withdrawals