chore: add OpEthApiBuilder and OpEthApiInner
#13009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-rpc
joshieDo
changed the title
storage_proofs_only to RollupArgsstorage_proof_only argument to RollupArgs
mattsse
requested changes
Nov 29, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
some suggestions, directionally lgtm
joshieDo
requested review from
Rjected,
emhane,
fgimenez and
gakonst
as code owners
mattsse
requested changes
Nov 30, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
pedantic style nits and opinionated suggestions
joshieDo
changed the title
storage_proof_only argument to RollupArgsOpEthApiBuilder and OpEthApiInner
mattsse
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
OpAddOnsBuilderOpEthApiBuilderOpEthApiInner