Closed
Conversation
This reverts commit 2e55be8.
…622) maps.Values() iterates in non-deterministic order, causing reconcileIPAddresses to produce randomly ordered IP address lists when multiple pools exist for the same device. Sort by the ProxmoxPoolOffsetAnnotation to preserve the NetworkSpec ordering. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Plugin mode no longer seems to work. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Vic Kerr <wiktor.kerr@ionos.com>
wikkyk
requested review from
65278,
mcbenjemaa and
pborn-ionos
as code owners
…rClass v0.1.0 support)
wikkyk
removed
the
e2e/none
wikkyk
added
the
e2e/none
After conversion, the restored object may end up with empty network elements which are culled. Iterating over the destination object may lead to out of bounds memory access.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreating #531
Issue #, if available:
#293
Description of changes:
I forward-ported 1d76694 to main. I ported all the new features to v1alpha2.
We'll ignore SonarQube's complaints of code duplication and insufficient testing for now. Some code will be duplicated as only parts of the API are changing.
Testing performed:
Keep tests working.
e2e/none label applied to reduce github spam.
TODOs (not exhaustive, some may be optional/obsolete):
infrav1