Merged
Conversation
wikkyk
requested review from
65278,
mcbenjemaa and
pborn-ionos
as code owners
TestsPlease note that running unit and e2e tests requires manual approval from a team member. e2e testsWe use labels to control which e2e tests contexts are run:
ℹ️ Ask a team member to add the requested labels if you don't have enough permissions. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
wikkyk
added
the
e2e/none
wikkyk
pushed a commit
that referenced
this pull request
Mar 10, 2026
Port linter configuration from v1alpha2/wip branch (PR #628) to main: - Add .golangci-kal.yml with kube-api-linter (KAL) module plugin config enabling 19 linters for Kubernetes API convention checking - Add .custom-gcl.yaml for building the KAL custom golangci-lint binary - Update .golangci.yml: replace dot-import path exclusions with staticcheck ST1001 and revive dot-imports rules, add SA1019 exclusion for deprecated v1beta1 CAPI imports, remove max-same-issues - Update .github/workflows/lint.yml: add lint-api CI job that builds and runs KAL alongside the existing golangci-lint action - Update Makefile: add lint-fix, lint-api, lint-api-fix, and golangci-lint-kal targets using the go tool approach https://claude.ai/code/session_011fW7hzA6AyAqK3jg9fuwqW
wikkyk
removed
the
e2e/none
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.75.0 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.75.0...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Closed
Co-authored-by: Felix Wischke (65278) <felix.wischke@ionos.com> Co-authored-by: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY
Issue #, if available:
#293
Description of changes:
I forward-ported 1d76694 to main. I ported all the new features to v1alpha2.
Testing performed:
All tests updated and pass.
TODOs (not exhaustive, some may be optional/obsolete):
Migrate to cluster-api v1beta2 API contract #605CAPI v1beta2 contract support and KAL alignment #639 Extra capi v1beta2 stuff #648- [ ] Stop using github.com/pkg/errors as it is unmaintainedStop using github.com/pkg/errors as it is unmaintained #654infrav1- [ ] Audit all usage of ptr.Deref and consider whether to replace with validator rules/default values and then simply deref pointersReduce usage of ptr.To and ptr.Deref #632