Assignment List Preferences (Filter, GroupBy, Grading Period) #2948

ndrsszsz · 2024-10-22T15:36:34Z

refs: MBL-14876
affects: Student, Teacher
release note: Added functionality to filter and group assignments.
test plan: See ticket

Assignment List screen

Add Filter icon in Navigation Bar (should turn to solid if there's an active filtering and that differs from the default settings).
Upgrade sections to be collapsable.

Assignment Filter screen

Grading Period section: Should only be visible if there are multiple Grading Periods (default option is All Grading Periods).
Group By section: Should always be visible (default option is Due Date).

Figma

Test Plan

See ticket.

Assignment Filter screen

Navigation bar title should contain the name of the course under the screen title.
Done button should always be visible and active.
Grading Period section of the screen should only be visible if there are multiple grading periods.
Default setting for grading periods is "All Grading Periods" right now. (Will be modified to the currently active grading period)
Sort By section should always be visible and should have "Due Date" option selected by default.
Changes are saved to userdefaults (except grading period settings).

Screenshots

Assignment List

Before	After

Assignment Filter

Before	After

Checklist

add - AssignmentFilterViewModel - enabling save button on change of previously set values remove - AssignmentListView - old filter button add - AssignmentFilterScreen - all button to enable selecting no grading periods

remove - unused code update - completion func to use struct instead of tuple update - unit tests rename - AssignmentListView to AssignmentListScreen

affects: Student, Teacher release note: Added Filter options to Assignment List test plan: See ticket

add - userdefaults support

…ent2

code cleanup

ndrsszsz · 2024-10-22T15:36:52Z

Unit tests will be added later.

inst-danger · 2024-10-22T15:40:06Z

	Warnings
⚠️	One or more files are below the minimum test coverage 50%

Release Note:

Added Filter options to Assignment List

Affected Apps: Student, Teacher

MBL-17932

Coverage	New %	Master %	Delta
Canvas iOS	91.43%	91.71%	-0.27%
Core/Core/Assignments/AssignmentList/ViewModel/AssignmentListViewModel.swift	47.8%	74.81%	-27.01%

Generated by 🚫 dangerJS against 71c15a3

…ent2

inst-danger · 2024-10-28T09:46:38Z

Teacher Build QR Code:

inst-danger · 2024-10-28T09:47:34Z

Student Build QR Code:

rh12

Great to see this coming together again after the design changes!

I've got a couple of small comments

Core/Core/Assignments/AssignmentList/View/AssignmentListPreferencesScreen.swift

Core/Core/InstUI/Views/Cells/CheckboxCell.swift

Core/Core/Assignments/AssignmentList/ViewModel/AssignmentListPreferencesViewModel.swift

suhaibabsi-inst · 2024-10-31T16:51:28Z

QA + 1

suhaibabsi-inst

Code +1
QA + 1

Please address above comments at your convenience.

suhaibabsi-inst

Thanks @ndrsszsz !

…ent2

rh12

QA + 1 again

…ent detail screen

vargaat

I compared my assignment list from the app to web and our list misses a few assignments even when all filter options are turned on: 1 from "Middle Group" and 2 from "Test Assignment Group". I haven't checked "Test Assignment Group" since there are too many assignments there.

vargaat

The issue I discovered is not related to this PR.

QA+1

rh12

QA + 1 again

Found some minor VoiceOver issues around ChecboxCell subtitles and the Filter button, but these can wait for the next PR. Discussed details offline.

ndrsszsz added 14 commits October 9, 2024 19:56

add - assignmentFilterScreen

c6a1022

commit

f1b6a32

update - RadioButtonCell - make value optional

196a8fb

add - AssignmentFilterViewModel - enabling save button on change of previously set values remove - AssignmentListView - old filter button add - AssignmentFilterScreen - all button to enable selecting no grading periods

add - sorting functionality

005f050

add - preview support

54d1e87

remove - unused code update - completion func to use struct instead of tuple update - unit tests rename - AssignmentListView to AssignmentListScreen

refs: MBL-17932

f0ecb5d

affects: Student, Teacher release note: Added Filter options to Assignment List test plan: See ticket

requested changes

05ef4aa

add - collapsable assignment sections

e29dd39

fix - AssignmentListViewModelTests

76215bd

update - Localizable.xcstrings

fc30c03

add - filtering functionality

b648666

add - userdefaults support

Merge branch 'master' into feature/MBL-17932-Assignment-list-improvem…

2cdd582

…ent2

update - filter icon behaviour

d1fa531

code cleanup

add - only show filter section if student

c2e2955

ndrsszsz requested review from vargaat, szabinst, rh12 and suhaibabsi-inst as code owners October 22, 2024 15:36

vargaat assigned ndrsszsz Oct 25, 2024

Merge branch 'master' into feature/MBL-17932-Assignment-list-improvem…

f09bebb

…ent2

ndrsszsz added 4 commits October 28, 2024 10:50

fix AssignmentListPreferencesScreen preview

c4ac7e5

delete - filterFilled icon (filterSolid is used instead)

30c030d

remove - filterFilled from InstIconExtensions

cf007de

requested change - remove unnecessary lines

a07c08f

rh12 reviewed Oct 29, 2024

View reviewed changes

requested changes

cadf45b

suhaibabsi-inst self-requested a review October 31, 2024 16:56

suhaibabsi-inst previously approved these changes Oct 31, 2024

View reviewed changes

requested changes

4acb0f5

ndrsszsz dismissed suhaibabsi-inst’s stale review via 4acb0f5 October 31, 2024 17:50

suhaibabsi-inst previously approved these changes Nov 3, 2024

View reviewed changes

requested changes

509bdcc

ndrsszsz dismissed suhaibabsi-inst’s stale review via 509bdcc November 4, 2024 11:21

ndrsszsz added 2 commits November 4, 2024 12:24

Merge branch 'master' into feature/MBL-17932-Assignment-list-improvem…

45cb848

…ent2

fix tests

618b4d0

rh12 previously approved these changes Nov 4, 2024

View reviewed changes

fix - preference settings not loaded when returning back from assignm…

68c1794

…ent detail screen

ndrsszsz dismissed rh12’s stale review via 68c1794 November 4, 2024 13:27

ndrsszsz added 4 commits November 4, 2024 18:04

update - filtering options

69f25b5

finalise assignment list filtering options

a55cedb

requested changes - assignment list filtering rule

403220a

update unit tests

fce281a

ndrsszsz force-pushed the feature/MBL-17932-Assignment-list-improvement2 branch from 1042156 to fce281a Compare November 5, 2024 13:30

ndrsszsz added 3 commits November 5, 2024 14:34

requested changes

e5f4de0

requested changes

ece8ed9

requested changes

e0ad587

vargaat requested changes Nov 6, 2024

View reviewed changes

requested changes

76794cf

vargaat previously approved these changes Nov 6, 2024

View reviewed changes

requested changes

71c15a3

ndrsszsz dismissed vargaat’s stale review via 71c15a3 November 6, 2024 13:03

rh12 approved these changes Nov 6, 2024

View reviewed changes

vargaat approved these changes Nov 6, 2024

View reviewed changes

ndrsszsz merged commit cb2f937 into master Nov 6, 2024
5 of 6 checks passed

ndrsszsz deleted the feature/MBL-17932-Assignment-list-improvement2 branch November 6, 2024 14:28

Assignment List Preferences (Filter, GroupBy, Grading Period) #2948

Assignment List Preferences (Filter, GroupBy, Grading Period) #2948

Uh oh!

Conversation

ndrsszsz commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Assignment List screen

Assignment Filter screen

Figma

Test Plan

Assignment Filter screen

Screenshots

Assignment List

Assignment Filter

Checklist

Uh oh!

ndrsszsz commented Oct 22, 2024

Uh oh!

inst-danger commented Oct 22, 2024 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Note:

Affected Apps: Student, Teacher

Uh oh!

inst-danger commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inst-danger commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

suhaibabsi-inst commented Oct 31, 2024

Uh oh!

suhaibabsi-inst left a comment

Choose a reason for hiding this comment

Uh oh!

suhaibabsi-inst left a comment

Choose a reason for hiding this comment

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

vargaat left a comment

Choose a reason for hiding this comment

Uh oh!

vargaat left a comment

Choose a reason for hiding this comment

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ndrsszsz commented Oct 22, 2024 •

edited

Loading

inst-danger commented Oct 22, 2024 •

edited by jira bot

Loading

inst-danger commented Oct 28, 2024 •

edited

Loading

inst-danger commented Oct 28, 2024 •

edited

Loading