requested changes

Author: ndrsszsz

Core/Core/Assignments/AssignmentList/View/AssignmentGroupView.swift

@@ -46,7 +46,6 @@ public struct AssignmentGroupView: View {
         .listRowSeparator(.hidden)
     }
 
-    @ViewBuilder
     private func headerView() -> some View {
         Button {
             isExpanded.toggle()

Core/Core/Assignments/AssignmentList/View/AssignmentListScreen.swift

@@ -68,7 +68,7 @@ public struct AssignmentListScreen: View, ScreenViewTrackable {
         return Section(
             header: ListSectionHeaderOld(backgroundColor: .backgroundLightest) {
                 HStack {
-                    Text("Grading Period:")
+                    Text("Grading Period:", bundle: .core)
                         .font(.regular14)
                         .fontWeight(.light)
                     Spacer()

Core/Core/Assignments/AssignmentList/ViewModel/AssignmentListPreferencesViewModel.swift

@@ -39,25 +39,25 @@ public struct AssignmentFilterOption: CaseIterable, Equatable {
 
     static let notYetSubmitted = Self(
         id: "notYetSubmitted",
-        title: "Not Yet Submitted",
-        subtitle: "Missing, Not Submitted",
+        title: String(localized: "Not Yet Submitted", bundle: .core),
+        subtitle: String(localized: "Missing, Not Submitted", bundle: .core),
         submissionRule: { submission in
             submission.missing && submission.submittedAt == nil
         }
     )
 
     static let toBeGraded = Self(
         id: "toBeGraded",
-        title: "To Be Graded",
-        subtitle: "Late, Submitted",
+        title: String(localized: "To Be Graded", bundle: .core),
+        subtitle: String(localized: "Late, Submitted", bundle: .core),
         submissionRule: { submission in
             submission.late && submission.submittedAt != nil
         }
     )
 
     static let graded = Self(
         id: "graded",
-        title: "Graded",
+        title: String(localized: "Graded", bundle: .core),
         submissionRule: { submission in
             submission.gradedAt != nil
         }

Core/Core/Assignments/AssignmentList/ViewModel/AssignmentListViewModel.swift

@@ -77,7 +77,7 @@ public class AssignmentListViewModel: ObservableObject {
             equals: courseID,
             orderBy: #keyPath(GradingPeriod.startDate)
         )
-        return env.subscribe(LocalUseCase(scope: scope)) { }
+        return env.subscribe(LocalUseCase(scope: scope))
     }()
 
     private lazy var assignmentGroups = env.subscribe(
@@ -115,7 +115,9 @@ public class AssignmentListViewModel: ObservableObject {
         sortingOption: AssignmentArrangementOptions? = nil,
         gradingPeriod: GradingPeriod?
     ) {
-        if gradingPeriod == selectedGradingPeriod && sortingOption == selectedSortingOption && filterOptions == selectedFilterOptions {
+        if gradingPeriod == selectedGradingPeriod
+            && sortingOption == selectedSortingOption
+            && filterOptions == selectedFilterOptions {
             return
         }
 

Core/Core/Localizable.xcstrings

@@ -179599,6 +179599,9 @@
           }
         }
       }
+    },
+    "Late, Submitted" : {
+
     },
     "Latest" : {
       "localizations" : {
@@ -198102,6 +198105,9 @@
           }
         }
       }
+    },
+    "Missing, Not Submitted" : {
+
     },
     "Module and all Items published" : {
       "localizations" : {
@@ -216535,6 +216541,9 @@
           }
         }
       }
+    },
+    "Not Yet Submitted" : {
+
     },
     "Note" : {
       "localizations" : {
@@ -328168,6 +328177,9 @@
           }
         }
       }
+    },
+    "To Be Graded" : {
+
     },
     "To create an account, have your student create a pairing code for you from the Settings section of the Canvas Student app as shown below, and then scan that code from here.\nIf your student doesn't see the option to create a pairing code, you'll need to reach out to your school to create your account." : {
       "localizations" : {