-
Notifications
You must be signed in to change notification settings - Fork 122
No file verifiers #2941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No file verifiers #2941
Conversation
[ignore-commit-lint]
affects: Student, Teacher, Parent release note: none test plan: - Log in to the beta environment. - Link course files to where rich content is enabled using a web browser. (Assignment, quiz, discussion, announcement, page, syllabus, calendar event) - Check the linked files is they are still working from the apps.
❌ XCTest failed: CoreTests/FileSubmissionItemsUploadStarterTests/testStartsFileUploadAndSetsTaskIDOnUploadTask
❌ XCTest failed: CoreTests/InboxMessageInteractorLiveTests/testRequestsNextPage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise: Looks good to me.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
# Conflicts: # Core/Core/ObserverAlerts/GetObserverAlerts.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review + 1
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
Everything seems to work, checked in prod environment
refs: MBL-17864
affects: Student, Teacher, Parent
release note: none
test plan:
Checklist