Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Oct 17, 2024

refs: MBL-17864
affects: Student, Teacher, Parent
release note: none

test plan:

  • Log in to the production environment.
  • Link and embed course files to where rich content is enabled using a web browser. (Assignment, quiz, discussion, announcement, page, syllabus, calendar event)
  • Check the linked files if they are still working from the apps.

Checklist

  • Follow-up e2e test ticket created

suhaibabsi-inst and others added 9 commits September 25, 2024 17:19
[ignore-commit-lint]
affects: Student, Teacher, Parent
release note: none

test plan:
- Log in to the beta environment.
- Link course files to where rich content is enabled using a web browser. (Assignment, quiz, discussion, announcement, page, syllabus, calendar event)
- Check the linked files is they are still working from the apps.
@vargaat vargaat requested review from szabinst and rh12 as code owners October 17, 2024 15:13
@vargaat vargaat self-assigned this Oct 17, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Oct 17, 2024

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: CoreTests/FileSubmissionItemsUploadStarterTests/testStartsFileUploadAndSetsTaskIDOnUploadTask
failed - Upload session not started.
❌ XCTest failed: CoreTests/InboxMessageInteractorLiveTests/testRequestsNextPage
API violation - multiple calls made to -[XCTestExpectation fulfill] for state reached. (NSInternalInconsistencyException)
Crash: CoreTester (13535) closure #1 in InboxMessageInteractorLiveTests.waitForState(_:)

Generated by 🚫 dangerJS against 091209b

@inst-danger
Copy link
Contributor

inst-danger commented Oct 17, 2024

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 17, 2024

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 17, 2024

Student Build QR Code:

Base automatically changed from bugfix/Xcode16-Fixes to master October 24, 2024 11:30
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise: Looks good to me.
+1

@suhaibabsi-inst suhaibabsi-inst self-requested a review October 24, 2024 12:39
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

# Conflicts:
#	Core/Core/ObserverAlerts/GetObserverAlerts.swift
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + 1

Thanks for the changes!

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1
Everything seems to work, checked in prod environment

@rh12 rh12 merged commit 49d9fff into master Oct 28, 2024
4 of 7 checks passed
@rh12 rh12 deleted the feature/MBL-17864-No-file-verifiers branch October 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants