Extract no verifier parameter to APIURLRequestable protocol.

Author: vargaat

Core/Core/API/APIRequestable.swift

@@ -165,6 +165,8 @@ public protocol APIRequestable {
     /// If this parameter is set to true, then we will use a custom percent encoding for every `URLQueryItem`  where the `"+"` sign is encoded alongside with the `urlHostAllowed` CharacterSet.
     /// Some APIs expect Date strings with the time zone attached where we need to encode the `+` sign.
     var useExtendedPercentEncoding: Bool { get }
+    /// This will make the API to omit the file verifier parameter when returning course file links in rich content.
+    var shouldAddNoVerifierQuery: Bool { get }
 
     func urlRequest(relativeTo: URL, accessToken: String?, actAsUserID: String?) throws -> URLRequest
     func decode(_ data: Data) throws -> Response
@@ -205,6 +207,8 @@ extension APIRequestable {
 
     public var useExtendedPercentEncoding: Bool { false }
 
+    public var shouldAddNoVerifierQuery: Bool { true }
+
     public func urlRequest(relativeTo baseURL: URL, accessToken: String?, actAsUserID: String?) throws -> URLRequest {
         guard var components = URLComponents(string: path) else { throw APIRequestableError.invalidPath(path) }
 
@@ -278,19 +282,7 @@ extension APIRequestable {
             extraQueryItems.append(URLQueryItem(name: "as_user_id", value: actAsUserID))
         }
 
-        let ignoreNoVerifierQueryRequests: [any APIRequestable.Type] = [
-            LoginWebRequest.self,
-            GetMobileVerifyRequest.self,
-            PostAccountUserRequest.self
-        ]
-        let shouldAddNoVerifierQuery: Bool = {
-            !ignoreNoVerifierQueryRequests.contains { ignorableType in
-                (type(of: self) == ignorableType)
-            }
-        }()
-
         if shouldAddNoVerifierQuery {
-            /// This will make the API to omit the file verifier parameter when linking course files.
             extraQueryItems.append(URLQueryItem(name: "no_verifiers", value: "1"))
         }
 

Core/Core/Login/APILoginWeb.swift

@@ -25,6 +25,7 @@ struct LoginWebRequest: APIRequestable {
     let provider: String?
 
     let path = "/login/oauth2/auth"
+    let shouldAddNoVerifierQuery = false
 
     var query: [APIQueryItem] {
         var items: [APIQueryItem] = [

Core/Core/Login/APIOAuth.swift

@@ -134,6 +134,7 @@ struct GetMobileVerifyRequest: APIRequestable {
         HttpHeader.accept: "application/json",
         HttpHeader.authorization: nil
     ]
+    let shouldAddNoVerifierQuery = false
 }
 
 // https://canvas.instructure.com/doc/api/file.oauth_endpoints.html#post-login-oauth2-token

Core/Core/Profile/Settings/APIPairingCode.swift

@@ -54,6 +54,7 @@ public struct PostAccountUserRequest: APIRequestable {
     public typealias Response = APIUser
     public let method: APIMethod = .post
     public var body: Body?
+    public let shouldAddNoVerifierQuery = false
     let baseURL: URL
     let accountID: String
     public var shouldHandleCookies: Bool = false