Skip to content

chore(model): update public deploy/undeploy to change desire state only #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023
Merged

chore(model): update public deploy/undeploy to change desire state only #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d1790
chore(model): update public deploy/undeploy to change desire state only
Aug 17, 2023
4f8dd71
chore: update to model id
Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions model/model/v1alpha/model.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,9 @@ message DeployModelRequest {

// DeployModelResponse represents a response for a deployed model
message DeployModelResponse {
// Deploy operation message
google.longrunning.Operation operation = 1;
// Deployed model's id
// Format: models/{model}
string model_id = 1;
}

// UndeployModelRequest represents a request to undeploy a model to offline
Expand All @@ -353,8 +354,9 @@ message UndeployModelRequest {

// UndeployModelResponse represents a response for a undeployed model
message UndeployModelResponse {
// Undeploy operation message
google.longrunning.Operation operation = 1;
// Undeployed model's id
// Format: models/{model}
string model_id = 1;
}

// GetModelCardRequest represents a request to query a model's README card
Expand Down
16 changes: 10 additions & 6 deletions openapiv2/openapiv2.swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4621,9 +4621,11 @@ definitions:
v1alphaDeployModelResponse:
type: object
properties:
operation:
$ref: '#/definitions/googlelongrunningOperation'
title: Deploy operation message
model_id:
type: string
title: |-
Deployed model's id
Format: models/{model}
title: DeployModelResponse represents a response for a deployed model
v1alphaDetectionInput:
type: object
Expand Down Expand Up @@ -6994,9 +6996,11 @@ definitions:
v1alphaUndeployModelResponse:
type: object
properties:
operation:
$ref: '#/definitions/googlelongrunningOperation'
title: Undeploy operation message
model_id:
type: string
title: |-
Undeployed model's id
Format: models/{model}
title: UndeployModelResponse represents a response for a undeployed model
v1alphaUnpublishModelResponse:
type: object
Expand Down