Skip to content

chore(model): update public deploy/undeploy to change desire state only #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2023
Merged

chore(model): update public deploy/undeploy to change desire state only #194

merged 2 commits into from
Aug 18, 2023

Conversation

heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Aug 17, 2023

Because

  • adopt changes in model-backend that public deploy/undeploy only change the desire state of the model

This commit

  • update public deploy/undeploy response to be model

@heiruwu heiruwu marked this pull request as ready for review August 17, 2023 16:23
donch1989
donch1989 previously approved these changes Aug 18, 2023
View reviewed changes
@heiruwu heiruwu requested a review from donch1989 August 18, 2023 07:39
@donch1989 donch1989 merged commit 49494bd into main Aug 18, 2023
@donch1989 donch1989 deleted the update-deploy-undeploy-model branch August 18, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @donch1989