-
-
Notifications
You must be signed in to change notification settings - Fork 7
recompute live-search in updateoptionalselectinput #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage Summary
Diff against main
Results for commit: 799b7e9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 11 suites 11s ⏱️ Results for commit e638046. |
Unit Tests Summary 1 files 11 suites 10s ⏱️ Results for commit 799b7e9. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donyunardi with fresh look I accept a PR. I see the point of setting only live-search
option when many choices available.
Fixes #291
live-search
inupdateOptionalSelectInput
.This is to anticipate choices being resolved in delayed data scenario. The logic to recompute is the same with this line:
teal.widgets/R/optionalInput.R
Line 185 in b9fc817
Code for testing