Merged
Conversation
plugins/inputs/tomcat/README.md
Outdated
| [[inputs.tomcat]] | ||
| # A Tomcat status URI to gather stats. | ||
| # Default is "http://127.0.0.1:8080/manager/status/all?XML=true". | ||
| url = http://127.0.0.1:8080/manager/status/all?XML=true |
plugins/inputs/tomcat/tomcat.go
Outdated
| var sampleconfig = ` | ||
| ## A Tomcat status URI to gather stats. | ||
| ## Default is "http://127.0.0.1:8080/manager/status/all?XML=true". | ||
| url = http://127.0.0.1:8080/manager/status/all?XML=true |
plugins/inputs/tomcat/tomcat.go
Outdated
| ## Cedentials for status URI. | ||
| ## Default is tomcat/s3cret. | ||
| username = "tomcat" | ||
| password = "s3cret" |
Contributor
There was a problem hiding this comment.
Fix up this indention because it is used directly in the sample config output. You can test with either of these commands:
telegraf --usage tomcat
telegraf config
plugins/inputs/tomcat/tomcat.go
Outdated
| ## A Tomcat status URI to gather stats. | ||
| ## Default is "http://127.0.0.1:8080/manager/status/all?XML=true". | ||
| url = http://127.0.0.1:8080/manager/status/all?XML=true | ||
| ## Cedentials for status URI. |
plugins/inputs/tomcat/README.md
Outdated
| # A Tomcat status URI to gather stats. | ||
| # Default is "http://127.0.0.1:8080/manager/status/all?XML=true". | ||
| url = http://127.0.0.1:8080/manager/status/all?XML=true | ||
| # Cedentials for status URI. |
Contributor
Author
|
updated comments / corrected typo. |
Contributor
danielnelson
left a comment
danielnelson
left a comment
There was a problem hiding this comment.
I just noticed we need to check the status code, also need to add to plugins/inputs/all/all.go.
| if err != nil { | ||
| return fmt.Errorf("Unable to call URL '%s': %s", s.URL, err) | ||
| } | ||
| defer resp.Body.Close() |
Contributor
There was a problem hiding this comment.
After checking for errors, we should make sure the response code was a 200 status and if not return an error.
Contributor
|
@mlindes I'll will do the change to address my last comment tomorrow. |
MrMaxBuilds
pushed a commit
that referenced
this pull request
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs: