Adding Tomcat plugin.

[mlindes]

This plugin resolves open issue #763 (#763)

Required for all PRs:

• CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
• Sign CLA (if not already signed)
• README.md updated (if adding a new plugin)

[mlindes]

Any chance this will make the 1.3 release?

[danielnelson]

No, I released a rc for 1.3 yesterday: #2733.

[nitin02]

Hi, Is this plugin release added to the next milestone? Which version will this plugin be available?

[toni-moreno]

We would like to test it!!

[danielnelson]

Looks great, can you fix one issue in the toml before I merge?

[danielnelson]

These strings need to be quoted so they are valid toml.

[danielnelson]

Remove this line

[danielnelson]

Quote toml strings here too.

[mlindes]

Quotes added. CircleCI complained about a zookeeper task. Not sure that's related to this pr.. I can follow-up if it is, though.

[danielnelson]

I think if you rebase it will fix the zookeeper issue.

[mlindes]

I don't really see how a rebase would solve this CircleCI error:

sudo service zookeeper stop
zookeeper: unrecognized service
sudo service zookeeper stop returned exit code 1
Action failed: sudo service zookeeper stop

Can you re-trigger the build to try it again? Permissions don't allow me to do that.
Otherwise, which tag would you like me to rebase off of. The first (successful) build was built from the 1.2.1 tag - which was the most current at the time of the PR.

[mlindes]

Oh sorry, I spoke too soon. I didn't notice the circle.yml file is totally different in the current base.
Looks like the latest change to circle.yml was after the 1.3.5 tag. Maybe I can just pull that one file. Thoughts?

[danielnelson]

I haven't tried that ever but when merge I will do a "Squash and merge" so as long as it does not introduce unwanted diffs it's fine.

[mlindes]

ok. I rebased off master, and tests now pass. The rebase introduced a few commits... but there hasn't been a tag or version release to use as a rebase point since the latest changes to the circle.yml file.

[danielnelson]

You will need to remove the unrelated commits during the rebase (use the -i flag).

[mlindes]

Accidentally closed this while trying to get our fork in sync.
Please check out the new PR - #3112