Skip to content

Fix #93: Uniform guard parsing #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbrujohalcon merged 1 commit into from
Jul 4, 2025
Merged

Fix #93: Uniform guard parsing #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 145 additions & 1 deletion test/ktn_code_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

-export([all/0, init_per_suite/1, end_per_suite/1]).
-export([
guards/1,
consult/1,
beam_to_string/1,
parse_tree/1,
Expand Down Expand Up @@ -47,7 +48,7 @@ all() ->
[parse_maybe, parse_maybe_else]
end,
Excluded = ?EXCLUDED_FUNS ++ DisabledMaybeTests,
[F || {F, _} <- Exports, not lists:member(F, Excluded)].
[F || {F, 1} <- Exports, not lists:member(F, Excluded)].

-spec init_per_suite(config()) -> config().
init_per_suite(Config) ->
Expand All @@ -69,6 +70,133 @@ enabled_features() ->
%% Test Cases
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

-spec guards(config()) -> ok.
guards(_Config) ->
%% One guard
[[#{type := atom, attrs := #{value := single_guard}}]] =
extract_guards(<<"f() -> case x of x when single_guard -> x end.">>),
%% Join with , - and - andalso
[
[
#{type := atom, attrs := #{value := first_guard}},
#{type := atom, attrs := #{value := second_guard}}
]
] = extract_guards(<<"f() -> case x of x when first_guard, second_guard -> x end.">>),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{type := atom, attrs := #{value := second_guard}}
],
attrs := #{operation := 'andalso'}
}
]
] =
extract_guards(<<"f() -> case x of x when first_guard andalso second_guard -> x end.">>),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{type := atom, attrs := #{value := second_guard}}
],
attrs := #{operation := 'and'}
}
]
] = extract_guards(<<"f() -> case x of x when first_guard and second_guard -> x end.">>),
%% Join with ; - or - orelse
[
[#{type := atom, attrs := #{value := first_guard}}],
[#{type := atom, attrs := #{value := second_guard}}]
] = extract_guards(<<"f() -> case x of x when first_guard; second_guard -> x end.">>),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{type := atom, attrs := #{value := second_guard}}
],
attrs := #{operation := 'orelse'}
}
]
] =
extract_guards(<<"f() -> case x of x when first_guard orelse second_guard -> x end.">>),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{type := atom, attrs := #{value := second_guard}}
],
attrs := #{operation := 'or'}
}
]
] = extract_guards(<<"f() -> case x of x when first_guard or second_guard -> x end.">>),
%% Combine ...
[
[#{type := atom, attrs := #{value := first_guard}}],
[
#{type := atom, attrs := #{value := second_guard}},
#{type := atom, attrs := #{value := third_guard}}
]
] = extract_guards(
<<"f() -> case x of x when first_guard; second_guard, third_guard -> x end.">>
),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{
type := op,
content := [
#{type := atom, attrs := #{value := second_guard}},
#{type := atom, attrs := #{value := third_guard}}
],
attrs := #{operation := 'andalso'}
}
],
attrs := #{operation := 'orelse'}
}
]
] =
extract_guards(
<<
"f() ->\n"
"case x of x when first_guard orelse second_guard andalso third_guard -> x end.\n"
""
>>
),
[
[
#{
type := op,
content := [
#{type := atom, attrs := #{value := first_guard}},
#{
type := op,
content := [
#{type := atom, attrs := #{value := second_guard}},
#{type := atom, attrs := #{value := third_guard}}
],
attrs := #{operation := 'and'}
}
],
attrs := #{operation := 'or'}
}
]
] =
extract_guards(
<<"f() -> case x of x when first_guard or second_guard and third_guard -> x end.">>
),
ok.

-spec consult(config()) -> ok.
consult(_Config) ->
[{a}, {b}] = ktn_code:consult("{a}. {b}."),
Expand Down Expand Up @@ -203,3 +331,19 @@ parse_generators(_Config) ->
shuffle(List) ->
Items = [{rand:uniform(), X} || X <- List],
[X || {_, X} <- lists:sort(Items)].

extract_guards(Source) ->
extract_guards([ktn_code:parse_tree(Source)], []).

extract_guards([], Guards) ->
Guards;
extract_guards([Node | Nodes], Guards) ->
extract_guards(
ktn_code:content(Node) ++
lists:flatten([maps:values(maps:get(node_attrs, Node, #{}))]) ++
Nodes,
case ktn_code:node_attr(guards, Node) of
undefined -> Guards;
Gs -> Guards ++ Gs
end
).