Skip to content

Conversation

@elbrujohalcon
Copy link
Member

@elbrujohalcon elbrujohalcon commented Jul 4, 2025

Fixes #93 by generating a uniform format for guards.

@elbrujohalcon
Copy link
Member Author

So, after adding these tests, I realized that we can workout in Elvis with what we currently have even if it's more complex.
But building spureous op nodes here to represent stuff that's not really an op, like ; and , would be tricky at best (we might get multiple things wrong, like precedence, line numbers, etc.) and really hard to get it right. For one thing in particular: Guards as a list can represent any number of expressions grouped by ; and any number of expressions grouped by ,. If we want to turn them into ops we need to properly nest them.

@elbrujohalcon
Copy link
Member Author

I'll merge these changes but I #wontfix the Issue.

@elbrujohalcon elbrujohalcon marked this pull request as ready for review July 4, 2025 14:57
@elbrujohalcon elbrujohalcon merged commit 2b2ad95 into main Jul 4, 2025
6 checks passed
@elbrujohalcon elbrujohalcon deleted the 93.guards branch July 4, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include information about the connectors used in guards

2 participants