Skip to content

Conversation

@vitoksmile
Copy link
Contributor

Description

Content is moved to top when selecting a photo in album (see attached video).

In this PR I display album image in AppBar even in selection mode, so the scrolling position remains unchanges.

How Has This Been Tested?

  • Navigate to Albums tab
  • Open any album
  • Long press to select a photo

Actual result: album image in AppBar is hidden and the content is scrolled top
Expected result: scrolling position remains unchanges

Screenshots

Actual behaviour:

album_actual.mp4

Fixed behaviour:

album_fixed.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

No LLM

return BaseBottomSheet(
controller: sheetController,
initialChildSize: 0.45,
initialChildSize: 0.18,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligned this change with PRs #22008 and #22085

@alextran1502
Copy link
Member

Thank you for the PR I like this approach because it doesn't make the page shift.

I think we probably can make this better by hiding the button of the app bar in this mode, so that the cancel/counter doesn't overlap the back button when we are on top of the page.

@vitoksmile
Copy link
Contributor Author

Thank you for the PR I like this approach because it doesn't make the page shift.

I think we probably can make this better by hiding the button of the app bar in this mode, so that the cancel/counter doesn't overlap the back button when we are on top of the page.

Hi Alex,
Thank you for looking into this PR.

I have pushed the changes to hide AppBar's back button in album.

Also I fixed MultiSelectStatusButton position to calculate it based on the actual statusbar height.

Video recording
album_updated.mp4

@alextran1502 alextran1502 enabled auto-merge (squash) September 17, 2025 14:24
@alextran1502 alextran1502 merged commit 0c0bec6 into immich-app:main Sep 17, 2025
46 checks passed
@vitoksmile vitoksmile deleted the bugfix/remote-album-bottom-sheet branch September 17, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants