Skip to content

Conversation

@vitoksmile
Copy link
Contributor

Description

BottomSheet on timeline is overlaping selected photos in selection mode (see attached video).

In this PR I set the initial size of BottomSheet as minimim size, so it does not take half of the screen.

How Has This Been Tested?

  1. Open timeline
  2. Long press to select a photo

Actual result: BottomSheet is overlaping is photo is on first half of the screen (on top).
Expected result: Selected photo is still visible until users manually expand the BottomSheet.

Screenshots

The actual behaviour:

timeline_actual.mp4

Fixed behaviour:

timeline_fixed.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

No LLM

@vitoksmile vitoksmile force-pushed the bugfix/timeline-bottom-sheet branch from dc6b423 to 6f1fdd1 Compare September 16, 2025 17:17
@github-actions github-actions bot added documentation Improvements or additions to documentation 🖥️web labels Sep 16, 2025
@vitoksmile vitoksmile force-pushed the bugfix/timeline-bottom-sheet branch from 6f1fdd1 to e534e36 Compare September 16, 2025 17:18
@vitoksmile
Copy link
Contributor Author

@danieldietzler could you update labels? we only need changelog:bugfix and mobile

Copy link
Member

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@alextran1502 alextran1502 enabled auto-merge (squash) September 17, 2025 02:12
@vitoksmile
Copy link
Contributor Author

@alextran1502 could you update labels for this PR to remove "documentation" and include "mobile" instead

@alextran1502 alextran1502 removed the documentation Improvements or additions to documentation label Sep 17, 2025
@alextran1502 alextran1502 merged commit 4dfa011 into immich-app:main Sep 17, 2025
44 checks passed
@vitoksmile vitoksmile deleted the bugfix/timeline-bottom-sheet branch September 17, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants