Skip to content

Conversation

@Johannbr
Copy link
Contributor

@Johannbr Johannbr commented Sep 1, 2025

Description

Use timeline instead of custom grid to manage geolocation in utilities.

How to use it ?

Same as previous feature, the differences are:

  • After applying the location update:
  • => Text shows GPS instead of city
  • => Refresh
  • => Text show the city
    This is because of the async update for reverse geocoding

Removed the button "Show assets without location"

  • the main usecase of this tool is to copy gps data from adjacent photos, the button does not seem very useful
  • we have to add specific property in bucketDto payload, and repository
  • we still can find photos without GPS by using CMD+F : "No GPS"

See comment here : #20758 (comment)
Timeline would be better to manage geolocation

Code update highlights

Added property and method to AssetGrid and AssetDateGroup :

  • customLayout
  • onThumbnailClick

Added withCoordinates in bucket payload
Added lattitute and longitude in bucket response

How Has This Been Tested?

  • Manual test

Screenshots (if appropriate)

Screen.Recording.2025-09-01.at.12.23.28_compressed_720p.mp4

@Johannbr Johannbr marked this pull request as ready for review September 1, 2025 10:45
@Johannbr
Copy link
Contributor Author

Johannbr commented Sep 5, 2025

@alextran1502, @jrasm91 just in case you didn't see this PR :-)
I found it much easier to use than the previous one with the datepicker.

@jrasm91
Copy link
Member

jrasm91 commented Sep 10, 2025

Nice work!

@jrasm91 jrasm91 merged commit 7a1c45c into immich-app:main Sep 10, 2025
55 of 56 checks passed
@kaziu687
Copy link
Contributor

CMD+F : "No GPS" is bad idea when you need to search photos without location in 20 years timeframe ("No gps" text will be found only on visible tiles)

@Johannbr Johannbr deleted the feat/geolocation-utility-timeline branch September 15, 2025 11:58
jochbru pushed a commit to pixelunioneu/immich that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants