Skip to content

fix: translations from background service #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

fix: translations from background service #18473

merged 2 commits into from
May 22, 2025

Conversation

shenlong-tanwen
Copy link
Member

Description

  • The background service was using the older asset loader resulting in keys not getting translated when notifications are shown from the background.

@shenlong-tanwen shenlong-tanwen requested a review from bo0tzz as a code owner May 22, 2025 12:14
@alextran1502 alextran1502 merged commit 15877dd into main May 22, 2025
49 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-background-translations branch May 22, 2025 20:13
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
@shenlong-tanwen @savely-krasovsky
fix: translations from background service (immich-app#18473)
8343748 
* fix: translations from background service

* test: generate translation before running tests

---------

Co-authored-by: shenlong-tanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackpollard zackpollard zackpollard approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

@bo0tzz bo0tzz Awaiting requested review from bo0tzz bo0tzz is a code owner

Assignees
No one assigned
Labels
changelog:bugfix 📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenlong-tanwen @zackpollard @alextran1502