Skip to content

Commit 15877dd

Browse files
fix: translations from background service (#18473)
* fix: translations from background service * test: generate translation before running tests --------- Co-authored-by: shenlong-tanwen <[email protected]>
1 parent 1b8fa51 commit 15877dd

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,11 @@ jobs:
504504
with:
505505
channel: 'stable'
506506
flutter-version-file: ./mobile/pubspec.yaml
507+
508+
- name: Generate translation file
509+
run: make translation
510+
working-directory: ./mobile
511+
507512
- name: Run tests
508513
working-directory: ./mobile
509514
run: flutter test -j 1

mobile/lib/services/localization.service.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// ignore_for_file: implementation_imports
22

3-
import 'package:flutter/foundation.dart';
4-
import 'package:easy_localization/src/asset_loader.dart';
53
import 'package:easy_localization/src/easy_localization_controller.dart';
64
import 'package:easy_localization/src/localization.dart';
5+
import 'package:flutter/foundation.dart';
76
import 'package:immich_mobile/constants/locales.dart';
7+
import 'package:immich_mobile/generated/codegen_loader.g.dart';
88

99
/// Workaround to manually load translations in another Isolate
1010
Future<bool> loadTranslations() async {
@@ -14,7 +14,7 @@ Future<bool> loadTranslations() async {
1414
supportedLocales: locales.values.toList(),
1515
useFallbackTranslations: true,
1616
saveLocale: true,
17-
assetLoader: const RootBundleAssetLoader(),
17+
assetLoader: const CodegenLoader(),
1818
path: translationsPath,
1919
useOnlyLangCode: false,
2020
onLoadError: (e) => debugPrint(e.toString()),

0 commit comments

Comments
 (0)