Skip to content

feat(web): improve individual share ux #17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

devsnek
Copy link
Contributor

@devsnek devsnek commented Apr 6, 2025

Description

Renders share assets of type INDIVIDUAL directly with AssetViewer instead of going through the GalleryViewer. This makes sharing an individual image a bit cleaner, as the person you share it with sees it directly when they open it, instead of having to click through the gallery. If public upload is enabled, then the GalleryViewer is still used. To keep the functionality consistent, some small changes were made to the AssetViewer as well.

note: most of this diff is indentation, i recommend reviewing with the "hide whitespace" option (append ?w=1 to the files url).

How Has This Been Tested?

  • Test A - single image + no public upload
  • Test B - multiple image + no public upload
  • Test C - single image + public upload
  • Test D - multiple image + public upload

Screenshots (if appropriate)

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@devsnek devsnek force-pushed the x/single-image-ux branch from 174dd22 to 62f55d7 Compare April 7, 2025 00:07
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 merged commit 6ae24fb into immich-app:main Apr 8, 2025
42 checks passed
@devsnek devsnek deleted the x/single-image-ux branch April 8, 2025 13:40
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants