Skip to content

fix: Use email or name when building community list view #7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 6 commits into from
Sep 16, 2024
Merged

fix: Use email or name when building community list view #7203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff03da7
fix: Use email or name when building community list view
microamp Mar 16, 2024
b1553c6
test: add test case
jennifer-richards Jul 25, 2024
a170b34
chore: remove debug
jennifer-richards Jul 25, 2024
45292bd
Merge branch 'main' into fix/no-persons-email-in-clist
microamp Sep 16, 2024
dbc6a38
fix: use name in community list menu when no active email is found
microamp Sep 16, 2024
114c525
Merge branch 'main' into fix/no-persons-email-in-clist
jennifer-richards Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ietf/community/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def view_list(request, email_or_name=None):
'meta': meta,
'can_manage_list': can_manage_community_list(request.user, clist),
'subscribed': subscribed,
"email_or_name": email_or_name,
})

@login_required
Expand Down
2 changes: 1 addition & 1 deletion ietf/templates/community/view_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h1>{{ clist.long_name }}</h1>
{% bootstrap_messages %}
{% if can_manage_list %}
<a class="btn btn-primary my-3"
href="{% url "ietf.community.views.manage_list" email_or_name=clist.person.email_address %}">
href="{% url "ietf.community.views.manage_list" email_or_name=email_or_name %}">
<i class="bi bi-gear"></i>
Manage list
</a>
Expand Down