fix: Use email or name when building community list view

[microamp]

Fixes #7036

An additional argument has been added to pass the email_or_name variable through.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (c7f6bde) to head (114c525).
Report is 70 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7203      +/-   ##
==========================================
+ Coverage   88.78%   88.83%   +0.04%     
==========================================
  Files         296      304       +8     
  Lines       41320    41501     +181     
==========================================
+ Hits        36687    36866     +179     
- Misses       4633     4635       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rjsparks]

Since this is fixing a crash bug, we should add, or modify an existing test to include, a test that exercises the condition that led to the crash.

That test should also cover the view for person Y after having constructed a person X with name N and email E, and a person Y with name N (note same name) but no email.

[rjsparks]

See the earlier note re: tests

[jennifer-richards]

Looks good to me, agree that it should have a test.

[jennifer-richards]

I added a test - which fails because it turns out this goes deeper. There's a similar issue in list_menu.html with the added wrinkle that it's included both in the view we're already touching and in group_documents.html.

[microamp]

I added a test - which fails because it turns out this goes deeper. There's a similar issue in list_menu.html with the added wrinkle that it's included both in the view we're already touching and in group_documents.html.

Thanks for having a go at it! (It was on my list at the code sprint, but I ran out of time.)

I'll have a look at the files you mentioned when I can.

[rjsparks]

@jennifer-richards @microamp Is this still something to pursue?

[jennifer-richards]

@jennifer-richards @microamp Is this still something to pursue?

Yes, original bug is still there afaik and I think this was a good approach.

[jennifer-richards]

lgtm

In my previous comments I was worried because the email_or_name variable is not set when the list_menu.html is included via group_documents.html in the group_documents() view. On closer review, there are guards in place so the email_or_name is not needed in the group context.