Skip to content

Refactor HostFuncsWrapper #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented May 9, 2025

This PR is a continuation of #479. I'll keep this PR in draft until #479 is merged.
The new changes in this PR (excluding #479) are here:
jprendes/hyperlight@host_function_2...jprendes:hyperlight:host_function_3

@jprendes
Copy link
Contributor Author

jprendes commented May 9, 2025

@danbugs when you have some bandwidth, PTAL, thanks! :-)

@jprendes jprendes added the kind/refactor For PRs that restructure or remove code without adding new functionality. label May 9, 2025
@jprendes jprendes force-pushed the host_function_3 branch 2 times, most recently from 45f60a9 to 4eb6170 Compare May 9, 2025 20:18
danbugs
danbugs previously approved these changes May 10, 2025
Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jprendes jprendes dismissed danbugs’s stale review May 10, 2025 05:25

The merge-base changed after approval.

@jprendes jprendes force-pushed the host_function_3 branch 2 times, most recently from 6186fda to 35f0b94 Compare May 10, 2025 08:15
ludfjig
ludfjig previously approved these changes May 12, 2025
Copy link
Contributor

@dblnz dblnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM.

@jprendes jprendes marked this pull request as ready for review May 12, 2025 12:48
@jprendes jprendes merged commit e99716a into hyperlight-dev:main May 12, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants