Skip to content

Remove unused FunctionDefinition and redundant FunctionsMap #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented May 9, 2025

The FunctionDefinition struct is unused and can be simple removed.
The FunctionsMap struct is just a thin wrapper around a HashMap that re-exposes the same API, so it can also be removed.

jprendes added 2 commits May 9, 2025 16:33
Signed-off-by: Jorge Prendes <[email protected]>
@jprendes jprendes added the kind/refactor For PRs that restructure or remove code without adding new functionality. label May 9, 2025
@jprendes
Copy link
Contributor Author

jprendes commented May 9, 2025

@danbugs PTAL :-)

Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @jprendes —I'm loving this cleanup 😁

@jprendes jprendes merged commit 2e1efff into hyperlight-dev:main May 10, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants