Skip to content

Fix: Server Makes Unverified Requests to External Sites Using User Input in lerobot/scripts/visualize_dataset_html.py #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kira-offgrid
Copy link

Context and Purpose:

This PR automatically remediates a security vulnerability:

  • Description: Data from request object is passed to a new server-side request. This could lead to a server-side request forgery (SSRF). To mitigate, ensure that schemes and hosts are validated against an allowlist, do not forward the response to the user, and ensure proper authentication and transport-layer security in the proxied request.
  • Rule ID: python.flask.security.injection.ssrf-requests.ssrf-requests
  • Severity: HIGH
  • File: lerobot/scripts/visualize_dataset_html.py
  • Lines Affected: 199 - 201

This change is necessary to protect the application from potential security risks associated with this vulnerability.

Solution Implemented:

The automated remediation process has applied the necessary changes to the affected code in lerobot/scripts/visualize_dataset_html.py to resolve the identified issue.

Please review the changes to ensure they are correct and integrate as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant