-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(docs): Update links in il_robots.mdx and il_sim.mdx to use absolute URLs #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Update links in il_robots.mdx and il_sim.mdx to use absolute URLs #1313
Conversation
Updated the relative file paths for `train.py` and `configuration_act.py` to their absolute URLs on the main branch of the GitHub repository. This prevents broken links when the documentation is viewed outside of the local repository structure.
Hi @tc-huang, Thanks for this PR and for fixing broken links in our Best, Caroline. |
Hi @CarolinePascal, Thanks for the review on this PR. I'll take a look at it soon. I expect to have this done by end of today or tomorrow. Best, tc-huang |
Updated the relative file paths for `train.py` and `configuration_act.py` to their absolute URLs on the main branch of the GitHub repository. This prevents broken links when the documentation is viewed outside of the local repository structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes broken documentation links in two MDX files by replacing relative file paths with absolute GitHub URLs. The relative paths were causing 404 errors when viewing the documentation on GitHub and the Hugging Face documentation site.
- Updates broken relative links to absolute GitHub URLs in documentation files
- Fixes navigation to
train.py
andconfiguration_act.py
files from documentation pages - Ensures links work correctly both in GitHub file previews and rendered documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
docs/source/il_sim.mdx | Updates two broken relative links to absolute GitHub URLs for train.py and configuration_act.py |
docs/source/il_robots.mdx | Updates the same two broken relative links to absolute GitHub URLs for train.py and configuration_act.py |
Hi @CarolinePascal, Thanks for your patience. I've pushed the updates to this PR. The main change was to replace relative file paths with their corresponding absolute GitHub URLs for links During this process, I noticed two things I'd like to bring to your attention: First, regarding the diff preview in this PR, the Additionally, I noticed that the link to the I'd appreciate your review. I'm happy to help with any further changes or adjustments. Thanks! Best, tc-huang |
Hi @tc-huang, Thank you for updating the links ! We're converging towards a fully functional documentation now 😎 Regarding your observations : I have noticed the same deep red highlights on the diff preview, without being able to identify its cause. As the documentation still builds and renders pages correctly, I think we can safely ignore this for now. The link to the Thank you again for your help ! Best, Caroline. |
The example link in `Dataset upload` was hardcoded with the username `cadene` (https://huggingface.co/datasets/cadene/so101_test), causing a 404 error and inconsistency with the `echo` command example below it, which uses `${HF_USER}` (https://huggingface.co/datasets/${HF_USER}/so101_test). This commit replaces `cadene` with `${HF_USER}` to ensure consistency.
Adds backticks around the dataset upload example link in `il_robots.mdx`. This prevents a `ReferenceError: HF_USER is not defined` that occurred when inspecting the `il_robots.mdx` document locally.
Hi @CarolinePascal, I've pushed the updates to change As a side note, I saw the same deep red highlighting in the Github code viewing mode of il_robots.mdx, which seems to confirm that the deep red highlighting in the diff preview in this PR wasn't introduced by the commits of this PR. Best, tc-huang |
Hi @CarolinePascal, Just a quick note to follow up on the PR. Please take a look when you have a moment, and let me know if you have any questions or feedback. Thanks, tc-huang |
Hi @tc-huang ! I'll merge the PR today :) Best, Caroline. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @CarolinePascal, Thank you for the review and for getting this merged. I appreciate your help. Best, tc-huang |
…te URLs (#1313) * Update links to use absolute URLs. * Update dataset upload example link to use HF_USER variable and match the correct syntax.
What this does
This PR fixes two broken links in the
il_robots.mdx
andil_sim.mdx
by replacing relative file paths with their corresponding absolute GitHub URLs.The relative paths were causing "404 Not Found" errors when viewing the file on GitHub because they were pointing to incorrect locations. Using absolute URLs ensures the links always resolve to the correct files in the
main
branch.Note
The same broken links also cause 404 errors on the documentation page: huggingface.co/docs/lerobot/il_robots and huggingface.co/docs/lerobot/il_sim.
The following changes were made in both
il_robots.mdx
andil_sim.mdx
:python -m lerobot.scripts.train
was updated:configuration_act.py
was updated:For example:
Before change: Clicking the


configuration_act.py
link in the GitHub file preview oflerobot/docs/source/il_robots.mdx
resulted in a 404 error, as it incorrectly pointed todocs/src/lerobot/policies/act/configuration_act.py
.After change: After updating the link to an absolute URL, it now correctly directs to the

configuration_act.py
file.How it was tested
I verified the fix by following the testing instructions provided for the reviewer below. The links now navigate to the correct pages both in the GitHub file preview and in the local documentation preview.
How to checkout & try? (for the reviewer)
1. Verify on GitHub
docs/source/il_robots.mdx
andil_sim.mdx
files.python -m lerobot.scripts.train
andconfiguration_act.py
) and confirm they lead to the correct files.2. Verify by previewing locally
doc-builder build lerobot docs/source/ --build_dir ~/tmp/test-build doc-builder preview lerobot docs/source/
Imitation Learning on Real-World Robots
andImitation Learning in Sim
pages from the left-hand navigation bar.python -m lerobot.scripts.train
andconfiguration_act.py
) to verify they work correctly.