Skip to content

Does Pi0 load the wrong PaliGemma config in case of missing model_type? #1325

@Qu3tzal

Description

@Qu3tzal

Why is this line

if "model_type" not in gemma_expert_config:

elif isinstance(self.paligemma_config, dict):
    # Override Pi0 default config for PaliGemma
    if "model_type" not in gemma_expert_config:
        paligemma_config["model_type"] = "paligemma"

    cfg_cls = CONFIG_MAPPING[paligemma_config["model_type"]]
    self.paligemma_config = cfg_cls(**paligemma_config)

and not

elif isinstance(self.paligemma_config, dict):
    # Override Pi0 default config for PaliGemma
    if "model_type" not in paligemma_config:
        paligemma_config["model_type"] = "paligemma"

    cfg_cls = CONFIG_MAPPING[paligemma_config["model_type"]]
    self.paligemma_config = cfg_cls(**paligemma_config)

?

So if we don't define the model type in the expert this triggers the reset of the PaliGemma model type?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn’t working correctlypoliciesItems related to robot policies

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions