Skip to content

Update card collapsed state handling to change child view model visibility attribute #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippjfr merged 17 commits into from
Jan 23, 2026
Merged

Update card collapsed state handling to change child view model visibility attribute #8274

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1a5861d
Update card collapsed state handling to change child view model visib…
dalthviz Oct 27, 2025
b3be0f9
Apply suggestions from code review
dalthviz Oct 30, 2025
d898e07
Set card content visibility only once if initially collapsed. Update …
dalthviz Oct 30, 2025
49c4f88
Merge branch 'main' into issue-8198
dalthviz Nov 4, 2025
82116b4
Merge branch 'main' into issue-8198
dalthviz Nov 14, 2025
b3bbf8a
Testing
dalthviz Nov 21, 2025
41da1fb
child_view visible handling simplification inside render
dalthviz Nov 21, 2025
45b68e5
Merge branch 'main' into issue-8198
dalthviz Nov 27, 2025
ac673ea
Merge branch 'main' into issue-8198
dalthviz Dec 1, 2025
da38821
Merge branch 'main' into issue-8198
philippjfr Dec 2, 2025
67b4f15
Add visible test
philippjfr Dec 2, 2025
7efff7a
Keep child elements visible attribute in sync with card collapsed value
dalthviz Dec 5, 2025
0508694
Fix style error
dalthviz Dec 5, 2025
483f8de
Testing
dalthviz Dec 5, 2025
6abc4ea
Merge branch 'main' into issue-8198
dalthviz Dec 5, 2025
3a3b82b
Track visible state
philippjfr Jan 20, 2026
6262509
Unregister callbacks
philippjfr Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions panel/models/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,8 @@ export class CardView extends ColumnView {
header.r_after_render()
}

if (this.model.collapsed) {
return
}

for (const child_view of this.child_views.slice(1)) {
child_view.model.visible = child_view.model.visible && !this.model.collapsed
Comment thread
philippjfr marked this conversation as resolved.
Outdated
this.shadow_el.appendChild(child_view.el)
child_view.render()
child_view.r_after_render()
Expand Down
Loading