Skip to content

Update card collapsed state handling to change child view model visibility attribute - #8274

Merged
philippjfr merged 17 commits into
holoviz:mainfrom
dalthviz:issue-8198
Jan 23, 2026
Merged

Update card collapsed state handling to change child view model visibility attribute#8274
philippjfr merged 17 commits into
holoviz:mainfrom
dalthviz:issue-8198

Conversation

@dalthviz

Copy link
Copy Markdown
Contributor

For an initial description of the approach followed for the proposed change you can check #8198 (comment)

Fixes #8198

@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (d93db73) to head (6262509).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8274      +/-   ##
==========================================
- Coverage   86.01%   85.99%   -0.02%     
==========================================
  Files         349      349              
  Lines       54647    54751     +104     
==========================================
+ Hits        47004    47084      +80     
- Misses       7643     7667      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread panel/models/card.ts Outdated
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Comment thread panel/models/card.ts Outdated
@dalthviz

Copy link
Copy Markdown
Contributor Author

Note: Closing and reopening to check if a CI rerun helps with the failing test_server_thread_pool_change_event[tornado] test

@dalthviz dalthviz closed this Nov 21, 2025
@dalthviz dalthviz reopened this Nov 21, 2025
@philippjfr

Copy link
Copy Markdown
Member

That one is flaky and unrelated.

@dalthviz

Copy link
Copy Markdown
Contributor Author

Yep, in my last commit I added a flaky decorator to that test and CI now is green. Let me know if there is something else that should be done here or if that last change I did should be reverted/moved to a different PR!

Comment thread panel/models/card.ts Outdated
@dalthviz

Copy link
Copy Markdown
Contributor Author

Note: Closing and reopening to retrigger CI

@dalthviz dalthviz closed this Nov 27, 2025
@dalthviz dalthviz reopened this Nov 27, 2025
Comment thread panel/tests/ui/layout/test_card.py Outdated
Comment thread panel/models/card.ts Outdated
@philippjfr
philippjfr merged commit 0317607 into holoviz:main Jan 23, 2026
32 of 39 checks passed
Copilot AI mentioned this pull request Jan 26, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card callback not called when collapsed by default

2 participants