-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix: Update K8s and Consul API dependencies to address security vulnerabilities #37150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SYSHIL <[email protected]>
|
Hi @Ilhan-Personal , thanks for your contribution! Could you please run |
|
Note for merging, this also needs the full acceptance tests for k8s and consul |
Signed-off-by: SYSHIL <[email protected]>
|
Hi @SarahFrench , Thank you! I've ran the script and pushed the changes |
|
@hashicorp/tf-eco-hybrid-cloud Could you test the Kubernetes backend following these changes please? |
|
I've figured out how to run the tests for the We just need to have the |
|
Just curious could you please maybe point me towards how you're testing these tests? |
SarahFrench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worked with the Hybrid Cloud team to get the kubernetes backend's tests run on this PR and they all passed, so I'm happy to approve & merge.
That backend is unmaintained, so I found a way to run the tests but it's almost definitely not the best way. What I did was:
There are a bunch of ENVs in the Consul SDK that might make this experience smoother, but I've got minimal Consul knowledge and haven't looked into ways to improve the test performance. Hopefully the instructions above are sufficient to get you started! |
|
Thank you so much @SarahFrench |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #37151
This PR addresses two security vulnerabilities by updating dependencies:
K8s Dependencies
Updated k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, and k8s.io/utils to v0.33.0
Fixes high severity DoS vulnerability in k8s.io/apimachinery/pkg/util/runtime (CVE referenced in SNYK-GOLANG-K8SIOAPIMACHINERYPKGUTILRUNTIME-8367153)
Minimum required version for fix: v0.29.0-alpha.3
HashiCorp Consul API
Updated to v1.32.1 to address potential security concerns
Changes have been applied to both the main module and Kubernetes remote state backend module. Build verification confirms Terraform builds successfully with these updates.