Skip to content

QueryContext() for context cancellation support #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanStough merged 2 commits into from
Mar 21, 2024
Merged

QueryContext() for context cancellation support #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b7004
QueryContext() for context cancellation support
jcodybaker Feb 18, 2024
6b01666
re-trigger ci
DanStough Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package mdns

import (
"context"
"fmt"
"log"
"net"
Expand Down Expand Up @@ -67,13 +68,31 @@ func DefaultParams(service string) *QueryParam {
// to a channel. Sends will not block, so clients should make sure to
// either read or buffer.
func Query(params *QueryParam) error {
return QueryContext(context.Background(), params)
}

// QueryContext looks up a given service, in a domain, waiting at most
// for a timeout before finishing the query. The results are streamed
// to a channel. Sends will not block, so clients should make sure to
// either read or buffer. QueryContext will attempt to stop the query
// on cancellation.
func QueryContext(ctx context.Context, params *QueryParam) error {
// Create a new client
client, err := newClient(!params.DisableIPv4, !params.DisableIPv6)
if err != nil {
return err
}
defer client.Close()

go func() {
select {
case <-ctx.Done():
client.Close()
case <-client.closedCh:
return
}
}()

// Set the multicast interface
if params.Interface != nil {
if err := client.setInterface(params.Interface); err != nil {
Expand Down