Skip to content

QueryContext() for context cancellation support#117

Merged
DanStough merged 2 commits intohashicorp:mainfrom
jcodybaker:add-query-context
Mar 21, 2024
Merged

QueryContext() for context cancellation support#117
DanStough merged 2 commits intohashicorp:mainfrom
jcodybaker:add-query-context

Conversation

@jcodybaker
Copy link
Copy Markdown
Contributor

This PR provides support client context cancellation by leveraging the existing unexported client.Close method. A new QueryContext method is added to avoid breaking backwards compatibility with Query().

@jcodybaker jcodybaker requested a review from a team as a code owner February 19, 2024 03:54
Copy link
Copy Markdown
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@DanStough DanStough merged commit 9f136d7 into hashicorp:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants