-
Notifications
You must be signed in to change notification settings - Fork 253
Status bar for listing view #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status bar for listing view #1459
Conversation
|
Ah, that seems easy to fix. |
|
Ah, was in |
|
looks great now! I feel fine merging this as-is but it may get tweaked... so I would rather iron out the changes here before merging. I still don't quite think the toggle button feels right. I think we discussed maybe a toggle button for whether the aspect ratio is respected. But having the toggle switch between compact and list view and gallery and new gallery view doesn't seem worth it. I think we discussed having the views change based on the size scale? What do you think about doing that instead, remove the toggle button and instead base it on size ? if size = 0 or 1 (out of 9) , use the minified view (compact list and new compact gallery view) |
|
Well for me this is finished 😅 I was thinking on do your suggestion but that may break all... Basically the two modes in gallery are two different modes, that's why I called one "icons view" and the other is still called gallery, which uses (very) bigger items on desktop, meanwhile on mobile I tried to mimic the look of native mobile gallery app. If I do that probably will need a complete re-write (again) of all, the columns calculation, the CSS... and probably don't will behave well because there will be very sudden changes in size because of the size levels. (And I'm not sure how to do it properly). However I think that I can do it for the list views as they are literally the same but without the indicator of But thinking about this- probably is better a setting/preference of group items instead, applicable for all the view modes and delete one of the list view modes, but that's maybe another separate feature. |
|
ok no worries -- this is 99% of what it should be so I think its perfectly fine to merge and it will be another week or so before release, im sure it will get tweaked in dev branches. |




Description
#1425
According to the contributing guide, A PR should contain:
Additional Details