-
Notifications
You must be signed in to change notification settings - Fork 253
Status bar and icons view mode for gallery view #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now the slider also changes the size of the listing modes - And the main switch button only cycles between three modes. 2025-10-23.22-37-32.mp4I think that I'm done! I'll update the translations. |
|
I'm not sure why that test is failing, but anyways. |
|
did you check the test failure output?
It shows the console errors that are happening, these are real test failures from your changes. The steps are all succeeding -- but there are console errors that are occuring during the process which is why it failed. see this test for steps to reproduce filebrowser/frontend/tests/playwright/general/navigation.spec.ts Lines 4 to 15 in 6d11e01
|
|
Finally, they now passed! Thanks for pointing where was the error. |
| const baseHeight = getters.viewMode() == "compact" | ||
| ? 40 + (state.user.gallerySize * 2) // 40px to 56px - compact | ||
| : 50 + (state.user.gallerySize * 3); // 50px to 74px - list | ||
| document.documentElement.style.setProperty( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the precedent was set poorly here... and now that I see a bunch of document.documentElement.style.setProperty i don't like it.
Before it was just one, I could fix this later if you want but this is kinda bad practice, because we have this reactive vue application and setting style properties via vanilla javascript document queries.
not a blocker, but this really should be done here or components/files/listingItem.vue as part of the vue component.
I could clean this up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for that... please do it if it's not a hassle and if there no other issue 😅
|
Something happened? |
|
Oh I think because the dev branch deleted the PR also closed |
|
Just reopen against main and I will move to a dev branch when its ready. I am going to release v1.0.0 sometime this weekend and it will probably get merged in v1.1.0 following next week |
|
Ah, I see, I'll do it then. 👍 |
|
***@***.***
El mar, 28 oct 2025, 3:34 p. m., Kevin B. ***@***.***>
escribió:
… *Kurami32* left a comment (gtsteffaniak/filebrowser#1425)
<#1425 (comment)>
Ah, I see, I'll do it then. 👍
—
Reply to this email directly, view it on GitHub
<#1425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSDPM2PL3SLHQ4YJFN62X6L3Z6ZKNAVCNFSM6AAAAACKBZGU6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJXHE2DCMRUGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|

Description
Continuation of #1404
The original PR changed, so I think that is better open a new one also including the latest changes.
Summarizing:
state.jsand related files.According to the contributing guide, A PR should contain:
Additional Details
2025-10-23.17-31-39.mp4