Skip to content

Cherry-pick #8333 to v1.72.x #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented May 19, 2025

Original PR: #8333
Related Issue: #8332

RELEASE NOTES:

  • balancer/least_request: fix panic on resolver errors.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (edf643f) to head (dcef656).
Report is 1 commits behind head on v1.72.x.

Files with missing lines Patch % Lines
balancer/leastrequest/leastrequest.go 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.72.x    #8339      +/-   ##
===========================================
+ Coverage    82.04%   82.22%   +0.18%     
===========================================
  Files          412      412              
  Lines        40373    40382       +9     
===========================================
+ Hits         33123    33204      +81     
+ Misses        5881     5825      -56     
+ Partials      1369     1353      -16     
Files with missing lines Coverage Δ
balancer/leastrequest/leastrequest.go 85.24% <44.44%> (-3.25%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal merged commit 3b5fa74 into grpc:v1.72.x May 19, 2025
14 of 16 checks passed
@arjan-bal arjan-bal deleted the cherrypick/8333-v1-72 branch May 19, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants