-
Notifications
You must be signed in to change notification settings - Fork 4.5k
balancer/least_request : Fix panic while handling resolver errors #8333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a leftover embedded balancer in least request that was never set in the code when it got refactored to pick first as leaf. As a result, method calls forwarded to the embedded balancer would panic. Remove the embedded balance and properly forward the missing methods. Fixes grpc#8332.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8333 +/- ##
==========================================
- Coverage 82.41% 82.32% -0.10%
==========================================
Files 419 419
Lines 42025 42034 +9
==========================================
- Hits 34637 34604 -33
- Misses 5944 5974 +30
- Partials 1444 1456 +12
🚀 New features to boost your workflow:
|
Looking at the coverage report, I'm unclear on why the test doesn't cover the added implementation... Will look into it. Good to review otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the fix.
There was a leftover embedded balancer in least request that was never set in the code when it got refactored to pick first as leaf. As a result, method calls forwarded to the embedded balancer would panic.
Remove the embedded balance and properly forward the missing methods.
Fixes #8332
RELEASE NOTES: