fix: adapt the iam binding update logic to the latest constraints #1838
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed as some recent updates to a dependency (google-cloud-resource-manager or its dependencies) broke the existing logic, and we are seeing the
error like this:
--> policy.bindings.append(new_binding)
TypeError: Expected a message object, but got {'role': 'roles/run.invoker', 'members': [...]}
product-auto-label
bot
added
size: xs
|
Let's try to update google3 first. That google.iam namespace is indeed problematic |
|
CC @parthea Did the gapic generator make a breaking change to no longer allow dictionary inputs? |
tswast
reviewed
Jun 23, 2025
There was a problem hiding this comment.
I'm a bit concerned that this indicates a breaking change happened in the resource manager client library. Please find the change that broke dictionaries. We might need to update our dependencies in setup.py and the constraints files if this breaking change was intended.
| } # Use a dictionary to avoid problematic google.iam namespace package. | ||
| new_binding = google.iam.v1.policy_pb2.Binding( | ||
| role=role, members=[service_account] | ||
| ) # Use a dictionary to avoid problematic google.iam namespace package. |
There was a problem hiding this comment.
This comment is now out-of-date.
Suggested change
| ) # Use a dictionary to avoid problematic google.iam namespace package. | |
| ) |
Could you try this in google3? I wonder if a //google/iam/v1:iam_policy_py_pb2 dependency was missing last time I tried it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as some recent updates to a dependency (google-cloud-resource-manager or its dependencies) broke the existing logic, and we are seeing the error like this:
--> policy.bindings.append(new_binding)
TypeError: Expected a message object, but got {'role': 'roles/run.invoker', 'members': [...]}
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issues 419589974, 425442503 🦕