Skip to content

fix: maxOutstandingMessages should enable PubSub FlowControl #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mihai-ghita
Copy link
Contributor

@mihai-ghita mihai-ghita commented Sep 11, 2024

fix: maxOutstandingMessages should be defined without maxOutstandingRequestBytes

#347

@mihai-ghita mihai-ghita requested a review from a team as a code owner September 11, 2024 06:16
@mihai-ghita mihai-ghita changed the title fix: maxOutstandingMessages should be defined without maxOutstandingR… fix: maxOutstandingMessages should enable PubSub FlowControl Sep 11, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 11, 2024
@mihai-ghita
Copy link
Contributor Author

mihai-ghita commented Sep 22, 2024

@kamalaboulhosn should I do something to start the "Kokoro - Test: Integration" step from the pipeline?

@kamalaboulhosn kamalaboulhosn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@mihai-ghita
Copy link
Contributor Author

mihai-ghita commented Oct 2, 2024

@yoshi-kokoro, @kamalaboulhosn can you help me with the logs of Kokoro steps that failed? I can not see the logs and I don't know what's the cause of the failed steps.

@matt-kwong matt-kwong merged commit 4c107d8 into googleapis:main Oct 25, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants