fix: maxOutstandingMessages should be defined without maxOutstandingRequestBytes (#349)

mihai-ghita · web-flow · commit 4c107d896930 · 2024-10-25T15:16:42.000-04:00
diff --git a/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkTask.java b/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkTask.java
@@ -433,7 +433,7 @@ private boolean useFlowControl() {
     // only enable flow control if at least one flow control config has been set
     return maxOutstandingRequestBytes
             != CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_REQUEST_BYTES
-        || maxOutstandingRequestBytes != CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_MESSAGES;
+        || maxOutstandingMessages != CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_MESSAGES;
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ private boolean useFlowControl() {`
`433`	`433`	`// only enable flow control if at least one flow control config has been set`
`434`	`434`	`return maxOutstandingRequestBytes`
`435`	`435`	`!= CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_REQUEST_BYTES`
`436`		`- \|\| maxOutstandingRequestBytes != CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_MESSAGES;`
	`436`	`+ \|\| maxOutstandingMessages != CloudPubSubSinkConnector.DEFAULT_MAX_OUTSTANDING_MESSAGES;`
`437`	`437`	`}`
`438`	`438`
`439`	`439`	`@Override`