Support date-based PyPI versioning and dev packages#2806
Merged
j2kun merged 1 commit intogoogle:mainfrom Mar 25, 2026
Merged
Conversation
asraa
approved these changes
Mar 24, 2026
j2kun
added
the
pull_ready
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
…neric When canonicalizing, secret.generic ops are hoisted when they are fully plaintext. But this doesn't copy the attributes of the op onto the new hoisted generic's result attrs, and then those aren't copied to the old generic's new input. This results in a segfault when running in debug mode, due to a segfault in printing secret.generic arg attributes (that expect the arg attr dict to have arg attrs for each i in the arg list). FUTURE_COPYBARA_INTEGRATE_REVIEW=#2806 from j2kun:pypi-date ae711c5 PiperOrigin-RevId: 889323354
Collaborator
|
Looks like pypi is STILL not happy? :( |
Collaborator
Author
I think #2817 will get past that next bump. Welcome to my life circa late 2025. Packaging is very annoying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the PyPI workflow from a manual semver-based versioning format to a date-based one. The main constraint here is that we can't require any commits during the release process (due to google/copybara limitations). So we replace the hard-coded version number with a dynamic config, and use setuptools-scm to extract the release label from the release workflow to use as a PyPI version label.
Created scripts/get_version.py to support logic for finding the right label and release name from the existing PyPI releases, which further supports a
*.dev2style of pushing dev wheels for testing.