fix: copy result attribtues when extracting single ops from secret.generic#2811
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
fix: copy result attribtues when extracting single ops from secret.generic#2811copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_889323354
branch
2 times, most recently
from
5fc0286 to
7a01a42
Compare
…neric When canonicalizing, secret.generic ops are hoisted when they are fully plaintext. But this doesn't copy the attributes of the op onto the new hoisted generic's result attrs, and then those aren't copied to the old generic's new input. This results in a segfault when running in debug mode, due to a segfault in printing secret.generic arg attributes (that expect the arg attr dict to have arg attrs for each i in the arg list). PiperOrigin-RevId: 889323354
copybara-service
bot
force-pushed
the
test_889323354
branch
from
7a01a42 to
927f386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: copy result attribtues when extracting single ops from secret.generic
When canonicalizing, secret.generic ops are hoisted when they are fully plaintext. But this doesn't copy the attributes of the op onto the new hoisted generic's result attrs, and then those aren't copied to the old generic's new input.
This results in a segfault when running in debug mode, due to a segfault in printing secret.generic arg attributes (that expect the arg attr dict to have arg attrs for each i in the arg list).