fix: Change UsageItem.Quantity from int to float64 #3610
+123
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase to master and try again. Also, please change the PR title to: |
The API doc is not consistent with the actual output from the api. The quantity is not an int, but a float.
DocEmmetBrown
force-pushed
the
guillaume/fix-extended-billing
branch
from
7cdf4e8 to
34ba363
Compare
DocEmmetBrown
changed the title
sorry for the mess. I didn't pay attention, and forgot to rebase 🤦 . Friday afternoon is hitting hard :) |
|
Even better title And in the PR description we could add "Follows #3605" |
|
related to github/docs#39074 |
DocEmmetBrown
changed the title
done 👍 |
alexandear
approved these changes
Jun 27, 2025
|
Just FYI... I'm not going to mark this as a breaking API change since this was originally introduced within the same major release cycle. |
|
Please fix the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API doc is not consistent with the actual output from the api.
The quantity is not an int, but a float.
Follows #3605