-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add new enhanced billing endpoints #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new enhanced billing endpoints #3605
Conversation
Thank you, @DocEmmetBrown! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3605 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.01%
==========================================
Files 184 184
Lines 16148 16180 +32
==========================================
+ Hits 14747 14779 +32
Misses 1227 1227
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
the new endpoints are available as per this doc: https://docs.github.com/en/enterprise-cloud@latest/rest/billing/enhanced-billing?apiVersion=2022-11-28#get-billing-usage-report-for-an-organization
99177f0
to
9c9cddf
Compare
this is done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown!
Just a few minor tweaks, please then we should be ready for a second LGTM+Approval before merging.
06d5fb1
to
2a368b7
Compare
@gmlewis: I think I addressed all the concerns. I'm unsure how to re-run codecov to see if the changes "fixed" the coverage issue 🤔 |
fixes #3592 |
Please add this to the PR description, so GitHub will automatically close the issue when the PR is merged. |
Could you test these endpoints manually? |
@alexandear: what do you mean ? writing a quick go file that would hit those endpoints ? or testing the github api from the cli ? |
As described in CONTRIBUTING.md:
|
oh, yeah, this was done, sorry for the confusion :)
|
Normally, when contributors simply "push" changes to a PR, reviewers can click on this button in GitHub in order to see only the parts that have changed since the last code review: However, when contributors use "force push", this is what reviewers see: In this repo, we ALWAYS use squash-and-merge so that the commit history is nice and clean, as demonstrated below, which is why we ask that all contributors (in CONTRIBUTING.md) please not use "force push", in order to make the lives of code reviewers easier. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown and @alexandear!
LGTM.
Merging.
Sorry about that @gmlewis , I should have paid more attention to the docs. Old habits die hard ;) Thanks for merging it ! |
No problem. We have a few contributors who do this on a regular basis, and I'm hoping that if I explain why I keep asking for no "force pushing" maybe someday they will remember to stop doing that. Thank you, @DocEmmetBrown! |
The new Enhanced billing platform is available as per the doc
This is (largely) generated by copilot, but still manually reviewed. Happy to make any change if needed.
Fixes: #3592