Skip to content

Add new enhanced billing endpoints #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DocEmmetBrown
Copy link
Contributor

@DocEmmetBrown DocEmmetBrown commented Jun 26, 2025

The new Enhanced billing platform is available as per the doc

This is (largely) generated by copilot, but still manually reviewed. Happy to make any change if needed.

Fixes: #3592

@gmlewis gmlewis changed the title add new enhanced billing endpoints Add new enhanced billing endpoints Jun 26, 2025
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 26, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Jun 26, 2025

Thank you, @DocEmmetBrown!
Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (5862e24) to head (fb8b9a1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
+ Coverage   91.32%   91.34%   +0.01%     
==========================================
  Files         184      184              
  Lines       16148    16180      +32     
==========================================
+ Hits        14747    14779      +32     
  Misses       1227     1227              
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DocEmmetBrown DocEmmetBrown force-pushed the guillaume/add-new-extended-billing branch from 99177f0 to 9c9cddf Compare June 26, 2025 21:13
@DocEmmetBrown DocEmmetBrown requested a review from alexandear June 26, 2025 21:20
@DocEmmetBrown
Copy link
Contributor Author

Thank you, @DocEmmetBrown! Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

this is done :)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown!
Just a few minor tweaks, please then we should be ready for a second LGTM+Approval before merging.

@DocEmmetBrown DocEmmetBrown force-pushed the guillaume/add-new-extended-billing branch from 06d5fb1 to 2a368b7 Compare June 27, 2025 06:58
@DocEmmetBrown DocEmmetBrown requested a review from gmlewis June 27, 2025 07:01
@DocEmmetBrown
Copy link
Contributor Author

Thank you, @DocEmmetBrown! Just a few minor tweaks, please then we should be ready for a second LGTM+Approval before merging.

@gmlewis: I think I addressed all the concerns. I'm unsure how to re-run codecov to see if the changes "fixed" the coverage issue 🤔

@DocEmmetBrown
Copy link
Contributor Author

fixes #3592

@alexandear
Copy link
Contributor

fixes #3592

Please add this to the PR description, so GitHub will automatically close the issue when the PR is merged.

@alexandear
Copy link
Contributor

Could you test these endpoints manually?

@DocEmmetBrown
Copy link
Contributor Author

Could you test these endpoints manually?

@alexandear: what do you mean ? writing a quick go file that would hit those endpoints ? or testing the github api from the cli ?

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Could you test these endpoints manually?

@alexandear: what do you mean ? writing a quick go file that would hit those endpoints ? or testing the github api from the cli ?

As described in CONTRIBUTING.md:

$ ./script/test.sh

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 27, 2025
@DocEmmetBrown
Copy link
Contributor Author

Could you test these endpoints manually?

@alexandear: what do you mean ? writing a quick go file that would hit those endpoints ? or testing the github api from the cli ?

As described in CONTRIBUTING.md:

$ ./script/test.sh

oh, yeah, this was done, sorry for the confusion :)

testing .
ok      github.com/google/go-github/v73/github  (cached)        coverage: 99.1% of statements
        github.com/google/go-github/v73/test/fields             coverage: 0.0% of statements
?       github.com/google/go-github/v73/test/integration        [no test files]
testing example
        github.com/google/go-github/v73/example/actionpermissions               coverage: 0.0% of statements
        github.com/google/go-github/v73/example/appengine               coverage: 0.0% of statements
        github.com/google/go-github/v73/example/basicauth               coverage: 0.0% of statements
        github.com/google/go-github/v73/example/codespaces/newreposecretwithxcrypto             coverage: 0.0% of statements
        github.com/google/go-github/v73/example/codespaces/newusersecretwithxcrypto             coverage: 0.0% of statements
        github.com/google/go-github/v73/example/commitpr                coverage: 0.0% of statements
        github.com/google/go-github/v73/example/listenvironments                coverage: 0.0% of statements
        github.com/google/go-github/v73/example/migrations              coverage: 0.0% of statements
        github.com/google/go-github/v73/example/newfilewithappauth              coverage: 0.0% of statements
        github.com/google/go-github/v73/example/newrepo         coverage: 0.0% of statements
        github.com/google/go-github/v73/example/newreposecretwithxcrypto                coverage: 0.0% of statements
        github.com/google/go-github/v73/example/ratelimit               coverage: 0.0% of statements
        github.com/google/go-github/v73/example/simple          coverage: 0.0% of statements
        github.com/google/go-github/v73/example/tokenauth               coverage: 0.0% of statements
        github.com/google/go-github/v73/example/topics          coverage: 0.0% of statements
        github.com/google/go-github/v73/example/verifyartifact          coverage: 0.0% of statements
testing scrape
ok      github.com/google/go-github/scrape      (cached)        coverage: 59.4% of statements
        github.com/google/go-github/scrape/example/scrape               coverage: 0.0% of statements
testing tools
ok      tools/metadata  (cached)        coverage: 81.7% of statements
testing tools/sliceofpointers
ok      tools/sliceofpointers   (cached)        coverage: 94.7% of statements

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Normally, when contributors simply "push" changes to a PR, reviewers can click on this button in GitHub in order to see only the parts that have changed since the last code review:

changes-2025-06-27_07-15-43

However, when contributors use "force push", this is what reviewers see:

force-commits-2025-06-27_07-16-38

In this repo, we ALWAYS use squash-and-merge so that the commit history is nice and clean, as demonstrated below, which is why we ask that all contributors (in CONTRIBUTING.md) please not use "force push", in order to make the lives of code reviewers easier. Thank you.

clean-glog-2025-06-27_07-21-00

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown and @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit a2e5acc into google:master Jun 27, 2025
9 of 10 checks passed
@DocEmmetBrown
Copy link
Contributor Author

Normally, when contributors simply "push" changes to a PR, reviewers can click on this button in GitHub in order to see only the parts that have changed since the last code review:

changes-2025-06-27_07-15-43

However, when contributors use "force push", this is what reviewers see:

force-commits-2025-06-27_07-16-38

In this repo, we ALWAYS use squash-and-merge so that the commit history is nice and clean, as demonstrated below, which is why we ask that all contributors (in CONTRIBUTING.md) please not use "force push", in order to make the lives of code reviewers easier. Thank you.

clean-glog-2025-06-27_07-21-00

Sorry about that @gmlewis , I should have paid more attention to the docs. Old habits die hard ;)

Thanks for merging it !

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Sorry about that @gmlewis , I should have paid more attention to the docs. Old habits die hard ;)

No problem. We have a few contributors who do this on a regular basis, and I'm hoping that if I explain why I keep asking for no "force pushing" maybe someday they will remember to stop doing that. Thank you, @DocEmmetBrown!

@DocEmmetBrown DocEmmetBrown deleted the guillaume/add-new-extended-billing branch June 27, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support for Github Enhanced Billing platform API
3 participants