Feature: Add per-runner “Disable/Pause”

[bircni]

This PR adds per-runner disable/enable support for Gitea Actions so a registered runner can be paused from picking up new jobs without unregistering.

Disabled runners stay registered and online but are excluded from new task assignment; running tasks are allowed to finish. Re-enabling restores pickup, and runner list/get responses now expose disabled state.

Also added an endpoint for testing http://localhost:3000/devtest/runner-edit/enable

Fixes: #36767

[bircni]

Authorship: Reviewed by Codex (GPT-5.3)

I reviewed PR #36776 end-to-end (models, migrations, API/web routes, conversion layer, templates, and integration tests) and I did not find any blocking issues.

What I validated:

• is_disabled persistence + migration path (models/migrations/v1_26/v326.go, test included)
• API enable/disable coverage across admin/user/org/repo routes
• Web enable/disable handlers and permission checks in shared runner settings
• Scheduler behavior change to prevent disabled runners from receiving new work (services/actions/task.go, models/actions/task.go)
• API response surface for disabled state (modules/structs/repo_actions.go, services/convert/convert.go)
• Integration coverage for toggle behavior and scope checks

Local checks run:

• go test -tags 'sqlite sqlite_unlock_notify' ./models/migrations/v1_26 -run Test_AddDisabledToActionRunner -count=1
• go test -tags 'sqlite sqlite_unlock_notify' ./services/actions -run TestNonExistent -count=1 (compile check)

@silverwind - first review with codex 5.3 😄

[Copilot]

Pull request overview

This PR adds a per-runner disable/pause feature for Gitea Actions, allowing admins to stop a registered runner from picking up new jobs without unregistering it. Disabled runners remain registered and online but are excluded from new task assignment; running tasks finish normally. Re-enabling a runner restores task pickup. The feature is exposed via REST API endpoints for all runner scopes (global/admin, org, user, repo) and through the existing web UI runner edit page.

Changes:

• DB migration (#326) adding is_disabled column to action_runner table, with model field IsDisabled, and SetRunnerDisabled() function that updates the field and bumps the task version inside a transaction
• New DisableRunner/EnableRunner API endpoints at all four scopes (admin/org/user/repo), with updated ActionRunner API struct exposing a disabled field and corresponding swagger documentation
• Web UI changes adding an enable/disable toggle button to the runner edit page, with a new actions.runners.availability status indicator and locale strings

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
models/actions/runner.go	Adds IsDisabled field and SetRunnerDisabled with transactional update + task version bump
models/actions/task.go	Adds IsDisabled guard in CreateTaskForRunner (defense-in-depth)
models/migrations/v1_26/v326.go + v326_test.go	DB migration adds is_disabled NOT NULL DEFAULT false column
models/migrations/migrations.go	Registers migration 326
modules/structs/repo_actions.go	Adds Disabled bool to ActionRunner API struct
services/actions/task.go	Adds IsDisabled early-exit guard in PickTask
services/actions/interface.go	Adds DisableRunner/EnableRunner to the API interface
services/convert/convert.go	Maps runner.IsDisabled to Disabled in API response
routers/api/v1/shared/runners.go	Implements shared updateRunnerDisabled, DisableRunner, EnableRunner
routers/api/v1/admin/runners.go + org/action.go + repo/action.go + user/runners.go	Scope-specific handler wrappers with swagger comments
routers/api/v1/api.go	Registers PUT /{runner_id}/disable and /{runner_id}/enable routes
routers/web/shared/actions/runners.go	Implements web RunnerDisablePost/RunnerEnablePost handlers
routers/web/web.go	Registers POST disable/enable web routes; adds devtest runner-edit routes
routers/web/devtest/runner_edit.go	Devtest handler for previewing enable/disable UI states
templates/shared/actions/runner_edit.tmpl	Adds availability status indicator and enable/disable toggle button
templates/devtest/runner-edit.tmpl	Devtest page for UI verification
templates/swagger/v1_json.tmpl	Adds swagger definitions for all new endpoints and disabled field in ActionRunner definition; fixes "an" → "a" article in repo/user endpoint summaries
options/locale/locale_en-US.json	Adds locale strings for availability label and enable/disable actions
tests/integration/api_actions_runner_test.go	Integration tests for disable/enable API at all scopes, including idempotency and scope-enforcement
tests/integration/actions_runner_modify_test.go	Web integration tests for disable/enable in runner modify flow
tests/integration/actions_job_test.go	End-to-end test verifying disabled runner does not pick up tasks but re-enabled runner does

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bircni]

@silverwind fixed copilots comments

[bircni]

anyone who can review? :-)

[lunny]

anyone who can review? :-)

I will take care of that, but it may take some time since the task is relatively large.

[bircni]

Found some issues fixing them

[bircni]

@lunny should be ready for a review now - rebased and fixed some stuff 😄

[silverwind]

1. fetchTaskOnce will panic on error (tests/integration/actions_runner_test.go): Uses assert.NoError which records the failure but continues execution. If FetchTask returns an error, resp is nil and resp.Msg.Task panics. Should use require.NoError to fail fast.

2. Consider a single toggle endpoint: Separate /disable and /enable endpoints result in 8 route registrations + 8 swagger handler functions for a boolean toggle. A single PATCH .../runners/{runner_id} with {"disabled": true/false} would halve the API surface and be more conventional REST. Though I understand this may be intentional for simplicity.

3. Redundant early-return in API handler: updateRunnerDisabled in routers/api/v1/shared/runners.go checks runner.IsDisabled == isDisabled before calling SetRunnerDisabled, but SetRunnerDisabled already has this exact same check. The API handler check just saves one function call — not worth the duplicated logic.

[bircni]

@silverwind which of these comments do you want fixed?

[silverwind]

1 and 3 at least. And don't ask me questions like that, it's your job to judge these comments :)

[bircni]

@silverwind is there something wrong with CI?
I didn't touch the part which raises errors now :-(

[bircni]

ig I found it: #36858

[bircni]

It was a lie :-( whyyyyy

[silverwind]

int64-related issues may be coming from #36858. Also I think you need to run make tidy.

[bircni]

@silverwind @lunny fixed and ready for review again

[wxiaoguang]

Don't force-push or rebase after review starts. It makes it very difficult to review new changes.

[lunny]

It's better if @Zettat123 could have a review.

• When a runner was disabled, it will become offline after a while.
• When a runner was converted from disable to enable, the pending tasks will not be picked

[bircni]

Merge queue not working?

[lunny]

Merge queue not working?

Merged manually.