Add resolve/unresolve review comment API endpoints by bircni · Pull Request #36441 · go-gitea/gitea

bircni · 2026-01-23T20:17:20Z

Summary

I added API endpoints to resolve and unresolve pull request review comments.
This mirrors the UI conversation resolve behavior and returns the updated PullReviewComment with resolver information.

Usage

New endpoints:

POST /repos/{owner}/{repo}/pulls/{index}/comments/{id}/resolve
POST /repos/{owner}/{repo}/pulls/{index}/comments/{id}/unresolve

Example:

curl -X POST -H "Authorization: token $TOKEN" -H "Accept: application/json" http://localhost:3000/api/v1/repos/OWNER/REPO/pulls/PR_INDEX/comments/COMMENT_ID/resolve

Copilot

Pull request overview

This PR adds API endpoints to resolve and unresolve pull request review comments, providing programmatic access to functionality that previously existed only in the UI.

Changes:

Added POST endpoints /repos/{owner}/{repo}/pulls/{index}/comments/{id}/resolve and /repos/{owner}/{repo}/pulls/{index}/comments/{id}/unresolve
Refactored ToPullReviewCommentList to extract a new ToPullReviewComment function for converting single comments
Updated Swagger documentation to reflect the new API endpoints

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
routers/api/v1/api.go	Registers the new resolve/unresolve routes with appropriate middleware for authentication and archive checks
routers/api/v1/repo/pull_review.go	Implements the handler functions with permission checks, validation, and response formatting
services/convert/pull_review.go	Refactors comment conversion logic to support both list and single comment conversion
templates/swagger/v1_json.tmpl	Adds OpenAPI/Swagger documentation for the new endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

routers/api/v1/repo/pull_review.go

lunny · 2026-01-24T04:39:41Z

It's better to add some tests

bircni · 2026-01-24T20:01:04Z

@lunny added some tests 😄

routers/api/v1/repo/pull_review.go

wxiaoguang · 2026-01-25T15:32:22Z

routers/api/v1/api.go

+						m.Post("/comments/{id}/resolve", reqToken(), mustNotBeArchived, repo.ResolvePullReviewComment)
+						m.Post("/comments/{id}/unresolve", reqToken(), mustNotBeArchived, repo.UnresolvePullReviewComment)


It doesn't need issue index, see the /issues/comments/{id}

Should it better go under /pulls/reviews as only review comments can be marked resolved?

While it could be not very useful to provide review id in url but there is already /pulls/review/{id}/comments endpoint that can be base for this

Issue endpoints have already deprecated the unnecessary index

// EditIssueCommentDeprecated modify a comment of an issue func EditIssueCommentDeprecated(ctx *context.APIContext) { // swagger:operation PATCH /repos/{owner}/{repo}/issues/{index}/comments/{id} issue issueEditCommentDeprecated

services/convert/pull_review.go

tests/integration/api_pull_review_test.go

delvh

Naming sounds fine, especially as GitHub does not seem to support any such route in their API, so we can't look at it.

routers/api/v1/repo/pull_review.go

bircni · 2026-01-26T19:48:46Z

@delvh @wxiaoguang i renamed all occurences of pull review to pull request review

wxiaoguang · 2026-01-27T02:57:14Z

ping @lafriks

wxiaoguang · 2026-01-28T01:47:18Z

ping @lafriks

ping @lafriks

wxiaoguang · 2026-01-29T03:03:17Z

ping @lafriks

ping @lafriks

ping @lafriks

bircni · 2026-01-30T11:37:52Z

@lafriks whats the final decision? Can you unblock it?

bircni · 2026-02-01T09:38:19Z

@lafriks ping

lafriks · 2026-02-01T10:38:26Z

I still believe that the same item's endpoints should be grouped together. Currently we have /pulls/review/{id}/comments endpoint to create review comments, I don't thing it's a good place to have other review related comments endpoints in other place now also.

What other @go-gitea/maintainers think?

wxiaoguang · 2026-02-01T10:54:50Z

I still believe that the same item's endpoints should be grouped together. Currently we have /pulls/review/{id}/comments endpoint to create review comments, I don't thing it's a good place to have other review related comments endpoints in other place now also.

Then you need to answer 2 questions before just saying "believe that the same item's endpoints should be grouped together":

How does the review/{id} id help in real world? Show a real case that the {id} is useful.
Why other "comments" APIs deprecated issues/{index}? Add resolve/unresolve review comment API endpoints #36441 (comment)

lafriks · 2026-02-01T11:38:57Z

I don't believe it's the best design but as issue comments follow the same pattern I won't block

I'm ok that it follows general pattern as with issue comments

wxiaoguang · 2026-02-01T11:58:39Z

I don't believe it's the best design but as issue comments follow the same pattern I won't block

Still don't understand why you "don't believe it's the best design" since the questions are still not answered.

silverwind · 2026-02-01T19:36:03Z

Something seems wrong with this merge, other PRs show unrelated error:

https://github.com/go-gitea/gitea/actions/runs/21568528769/job/62143809600?pr=36457

Error: tests/integration/api_pull_review_test.go:384:145: not enough arguments in call to pull_service.CreateCodeComment
	have ("context".Context, *"code.gitea.io/gitea/models/user".User, *"code.gitea.io/gitea/modules/git".Repository, *"code.gitea.io/gitea/models/issues".Issue, number, string, string, bool, number, string, nil)
	want ("context".Context, *"code.gitea.io/gitea/models/user".User, *"code.gitea.io/gitea/modules/git".Repository, *"code.gitea.io/gitea/models/issues".Issue, int64, int64, int64, string, string, bool, int64, string, []string)
make[1]: *** [/home/runner/work/gitea/gitea/Makefile:636: integrations.pgsql.test] Error 1

silverwind · 2026-02-01T19:46:14Z

Actually no, it's just a bug in #36457.

* giteaofficial/main: (26 commits) [skip ci] Updated translations via Crowdin Remove and forbid `@ts-expect-error` (go-gitea#36513) Add resolve/unresolve review comment API endpoints (go-gitea#36441) Fix incorrect vendored detections (go-gitea#36508) Bump alpine to 3.23, add platforms to `docker-dryrun` (go-gitea#36379) Unify repo names in system notices (go-gitea#36491) Allow scroll propagation outside code editor (go-gitea#36502) Refactor ActionsTaskID (go-gitea#36503) Update JS deps, remove `knip`, misc tweaks (go-gitea#36499) [skip ci] Updated translations via Crowdin Fix editorconfig not respected in PR Conversation view (go-gitea#36492) Add FOLDER_ICON_THEME configuration option (go-gitea#36496) Don't create self-references in merged PRs (go-gitea#36490) Use reserved .test TLD for unit tests (go-gitea#36498) Fix bug when list pull request commits (go-gitea#36485) Update some go dependencies (go-gitea#36489) chore: add comments for "api/healthz", clean up test env (go-gitea#36481) [SECURITY] Toolchain Update to Go 1.25.6 (go-gitea#36480) [skip ci] Updated translations via Crowdin Render merged pull request title as such in dashboard feed (go-gitea#36479) ...

* origin/main: (1246 commits) fix(packages/container): data race when uploading container blobs concurrently (go-gitea#36524) [skip ci] Updated translations via Crowdin Remove and forbid `@ts-expect-error` (go-gitea#36513) Add resolve/unresolve review comment API endpoints (go-gitea#36441) Fix incorrect vendored detections (go-gitea#36508) Bump alpine to 3.23, add platforms to `docker-dryrun` (go-gitea#36379) Unify repo names in system notices (go-gitea#36491) Allow scroll propagation outside code editor (go-gitea#36502) Refactor ActionsTaskID (go-gitea#36503) Update JS deps, remove `knip`, misc tweaks (go-gitea#36499) [skip ci] Updated translations via Crowdin Fix editorconfig not respected in PR Conversation view (go-gitea#36492) Add FOLDER_ICON_THEME configuration option (go-gitea#36496) Don't create self-references in merged PRs (go-gitea#36490) Use reserved .test TLD for unit tests (go-gitea#36498) Fix bug when list pull request commits (go-gitea#36485) Update some go dependencies (go-gitea#36489) chore: add comments for "api/healthz", clean up test env (go-gitea#36481) [SECURITY] Toolchain Update to Go 1.25.6 (go-gitea#36480) [skip ci] Updated translations via Crowdin ... # Conflicts: # modules/templates/helper.go # options/locale/locale_en-US.ini # routers/web/repo/cherry_pick.go # routers/web/repo/editor.go # routers/web/repo/patch.go # templates/repo/editor/edit.tmpl # web_src/js/features/codeeditor.ts

@TheFox0x7

I'd like to apply as a maintainer. Thanks to @TheFox0x7 for the suggestion. Merged PRs: - #36441 - #36571 - #36603 - #36768 - #36776 - #36783 - #36876 - #36883 - #36924 Ongoing work: - #36514 - #36752 - #36912

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2026

github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 23, 2026

bircni force-pushed the feature/review-comment-api branch from 58a4c69 to a928f12 Compare January 23, 2026 23:08

silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 24, 2026

silverwind requested a review from Copilot January 24, 2026 02:29

Copilot started reviewing on behalf of silverwind January 24, 2026 02:29 View session

Copilot AI reviewed Jan 24, 2026

View reviewed changes

routers/api/v1/repo/pull_review.go Outdated Show resolved Hide resolved

routers/api/v1/repo/pull_review.go Show resolved Hide resolved

bircni force-pushed the feature/review-comment-api branch 2 times, most recently from 4f90506 to 5bff286 Compare January 24, 2026 20:00

lunny added this to the 1.26.0 milestone Jan 25, 2026

lunny approved these changes Jan 25, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2026