fix(repo-editor): disable Monaco `editContext` to avoid bugs with lost focus by tyroneyeh · Pull Request #36585 · go-gitea/gitea

tyroneyeh · 2026-02-11T07:45:51Z

Currently, pressing the space key in the Monaco editor scrolls the page instead of inserting a space
if the editor is focused. This PR stops the space key event from propagating to parent elements,
which prevents unwanted page scrolling while still allowing Monaco to handle space input normally.

Changes:

disable Monaco editContext

No changes to default editor behavior are needed; Monaco automatically inserts the space character.

silverwind · 2026-02-11T07:52:08Z

Currently, pressing the space key in the Monaco editor scrolls the page

On which browsers are you seeing this? I can not reproduce on Firefox and Chrome on MacOS at least.

tyroneyeh · 2026-02-11T09:07:26Z

On which browsers are you seeing this? I can not reproduce on Firefox and Chrome on MacOS at least.

I only have a problem with Chrome on Linux Plasma6, tab key is ok

silverwind · 2026-02-11T09:27:06Z

Maybe it's losing focus somehow? I found microsoft/monaco-editor#5081. Check if microsoft/monaco-editor#5081 (comment) also works.

This reverts commit 52ccec2.

tyroneyeh · 2026-02-11T10:17:00Z

add editContext: false is work

silverwind · 2026-02-11T10:42:44Z

That might be the better workaround. Are you doing anything unusual to trigger the bug like "moving browser windows between monitors" like mentioned in that issue?

web_src/js/features/codeeditor.ts

Signed-off-by: silverwind <me@silverwind.io>

silverwind · 2026-02-11T10:45:34Z

Added backport label because editContext was added in Monaco 0.53 and that version is in use in the v1.25 branch.

tyroneyeh · 2026-02-11T11:29:55Z

That might be the better workaround. Are you doing anything unusual to trigger the bug like "moving browser windows between monitors" like mentioned in that issue?

Nothing special, just open the file and click edit.

Copilot

Pull request overview

This PR aims to address Monaco editor focus/input issues by disabling Monaco’s editContext integration in the repo’s code editor configuration.

Changes:

Set editContext: false in the shared Monaco baseOptions (with a reference to microsoft/monaco-editor#5081).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

web_src/js/features/codeeditor.ts

GiteaBot · 2026-02-12T20:34:45Z

I was unable to create a backport for 1.25. @tyroneyeh, please send one manually. 🍵

go run ./contrib/backport 36585
...  // fix git conflicts if any
go run ./contrib/backport --continue

…t focus (go-gitea#36585) Currently, pressing the space key in the Monaco editor scrolls the page instead of inserting a space if the editor is focused. This PR stops the space key event from propagating to parent elements, which prevents unwanted page scrolling while still allowing Monaco to handle space input normally. Changes: - disable Monaco editContext No changes to default editor behavior are needed; Monaco automatically inserts the space character. --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io>

…t focus (#36585) Currently, pressing the space key in the Monaco editor scrolls the page instead of inserting a space if the editor is focused. This PR stops the space key event from propagating to parent elements, which prevents unwanted page scrolling while still allowing Monaco to handle space input normally. Changes: - disable Monaco editContext No changes to default editor behavior are needed; Monaco automatically inserts the space character. Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io>

* origin/main: (2555 commits) automate updating nix flakes (go-gitea#35641) Update AGENTS.md instructions (go-gitea#36627) use user id in noreply emails (go-gitea#36550) feat(db): Improve BuildCaseInsensitiveLike with lowercase (go-gitea#36598) [skip ci] Updated translations via Crowdin BUG: Fix workflow run jobs API returning null steps (go-gitea#36603) Refactor highlight and diff (go-gitea#36599) Fix bug when do LFS GC (go-gitea#36500) feature to be able to filter project boards by milestones (go-gitea#36321) Update emoji data for Unicode 16 (go-gitea#36596) Adapt monaco error matching pattern to recent webpack config change (go-gitea#36533) Fix a bug user could change another user's primary email (go-gitea#36586) fix(repo-editor): disable Monaco `editContext` to avoid bugs with lost focus (go-gitea#36585) Fine tune diff highlighting (go-gitea#36592) Add code editor setting dropdowns (go-gitea#36534) Update to go 1.26.0 and golangci-lint 2.9.0 (go-gitea#36588) Improve diff highlighting (go-gitea#36583) Fix markup code block layout (go-gitea#36578) Remove striped tables in UI (go-gitea#36509) Fix vertical alignment of `.commit-sign-badge` children (go-gitea#36570) ... # Conflicts: # custom/conf/app.example.ini # docs/content/administration/config-cheat-sheet.en-us.md # docs/content/administration/config-cheat-sheet.zh-cn.md # modules/setting/security.go # routers/common/errpage.go # services/context/api.go # services/context/context.go

…t focus (go-gitea#36585) Currently, pressing the space key in the Monaco editor scrolls the page instead of inserting a space if the editor is focused. This PR stops the space key event from propagating to parent elements, which prevents unwanted page scrolling while still allowing Monaco to handle space input normally. Changes: - disable Monaco editContext No changes to default editor behavior are needed; Monaco automatically inserts the space character. --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io>

fix(repo-editor): stop space propagation in Monaco

52ccec2

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2026

github-actions bot added the modifies/frontend label Feb 11, 2026

tyroneyeh added 2 commits February 11, 2026 18:15

Revert "fix(repo-editor): stop space propagation in Monaco"

1458dc8

This reverts commit 52ccec2.

Add editContext tofalse to baseOptions for monaco editor

230905b

silverwind reviewed Feb 11, 2026

View reviewed changes

web_src/js/features/codeeditor.ts Outdated Show resolved Hide resolved

Apply suggestion from @silverwind

9fef65b

Signed-off-by: silverwind <me@silverwind.io>

silverwind added type/bug backport/v1.25 labels Feb 11, 2026

silverwind changed the title ~~fix(repo-editor): stop space propagation in Monaco editor~~ fix(repo-editor): disable Monaco editContext to avoid bugs with spacebar Feb 11, 2026

silverwind approved these changes Feb 11, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2026

silverwind changed the title ~~fix(repo-editor): disable Monaco editContext to avoid bugs with spacebar~~ fix(repo-editor): disable Monaco editContext to avoid bugs with lost focus Feb 11, 2026

silverwind requested a review from Copilot February 11, 2026 18:08

Copilot started reviewing on behalf of silverwind February 11, 2026 18:08 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

web_src/js/features/codeeditor.ts Show resolved Hide resolved

silverwind changed the title ~~fix(repo-editor): disable Monaco editContext to avoid bugs with lost focus~~ fix(repo-editor): disable Monaco editContext to avoid bugs with lost focus Feb 11, 2026

lunny approved these changes Feb 12, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2026

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 12, 2026

silverwind enabled auto-merge (squash) February 12, 2026 18:35

Merge branch 'main' into main_codeEditorCannotSpace

d0f8e95

silverwind merged commit 514f322 into go-gitea:main Feb 12, 2026
24 checks passed

GiteaBot added this to the 1.26.0 milestone Feb 12, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 12, 2026

GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 12, 2026

tyroneyeh deleted the main_codeEditorCannotSpace branch February 12, 2026 23:07

tyroneyeh mentioned this pull request Feb 13, 2026

Fix focus lost bugs in the Monaco editor #36609

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(repo-editor): disable Monaco `editContext` to avoid bugs with lost focus#36585

fix(repo-editor): disable Monaco `editContext` to avoid bugs with lost focus#36585
silverwind merged 5 commits intogo-gitea:mainfrom
tyroneyeh:main_codeEditorCannotSpace

tyroneyeh commented Feb 11, 2026 •

edited

Loading

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

GiteaBot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

tyroneyeh commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

Uh oh!

silverwind commented Feb 11, 2026

Uh oh!

tyroneyeh commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

GiteaBot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tyroneyeh commented Feb 11, 2026 •

edited

Loading