use user id in noreply emails

[TheFox0x7]

This implements id based hidden emails in format of user+id@NoReplyAddress

resolves: #33471

---

The change is not breaking however it is recommended for users to move to this newer type of no reply address

[lunny]

The ID should not be leaked to outside of the system?

[TheFox0x7]

I've tested it manually in UI somewhat and I didn't found any issues so far, it handles both styles and keeps track of user after name change.
The only place which uses old style of emails is PAM - services/auth/source/pam/source_authenticate.go, but changing that would require fetching the user after creation and updating the email. Plus I'm really not sure PAM if is wildly used and since the change works with old ones I'm not sure it's worth the effort.

---

The ID should not be leaked to outside of the system?

• /users/search allows to look up user by id
• query to the above endpoint returns the id for each user in the list
• /users/{username} returns the id

It's not a secret.

[Copilot]

Pull request overview

Updates Gitea’s “keep email private” noreply address format to be ID-based (name+id@NoReplyAddress) so commits remain associated with the correct account even after username changes.

Changes:

• Generate placeholder (noreply) emails as lowername+uid@NoReplyAddress.
• Extend user lookup by email to recognize both legacy name@NoReplyAddress and new name+id@NoReplyAddress formats.
• Update and expand integration/unit tests to assert the new noreply format and related lookup behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tests/integration/repofiles_change_test.go	Updates expected commit author/committer noreply emails to include +id.
tests/integration/editor_test.go	Updates web editor commit email expectation for “keep private” default to include +id.
models/user/user_test.go	Adds/extends test cases to cover user+id@NoReplyAddress resolution and conflicts.
models/user/user.go	Switches placeholder generation to +id and updates lookup logic to support ID-based aliases.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Enzime]

Should this match GitHub's id+username@... format instead as the ID can't change but your username might change

see: https://docs.github.com/en/account-and-profile/reference/email-addresses-reference#your-noreply-email-address

[TheFox0x7]

not github's per say but yeah. It should be a correct subaddress correctly working subaddress which this isn't. Will fix.