Skip to content

Refactor Nuget Auth to reuse Basic Auth Token Validation#36558

Merged
wxiaoguang merged 5 commits intogo-gitea:mainfrom
ChristopherHX:refac-nuget-auth
Feb 8, 2026
Merged

Refactor Nuget Auth to reuse Basic Auth Token Validation#36558
wxiaoguang merged 5 commits intogo-gitea:mainfrom
ChristopherHX:refac-nuget-auth

Conversation

@ChristopherHX
Copy link
Copy Markdown
Contributor

@ChristopherHX ChristopherHX commented Feb 8, 2026

  • Implicitly handle Actions Task Token for Nuget Api Keys
  • Support same tokens as Basic Auth in Nuget Api Key Header

@ChristopherHX
Refactor Nuget Auth to reuse Basic Auth Token Validation
eddbf5c 
* Implicitly handle Actions Task Token for Nuget Api Keys
* Support same tokens as Basic Auth in Nuget Api Key Header
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2026
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Feb 8, 2026
ChristopherHX
ChristopherHX commented Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful to enable Actions Token Authentication in #36173 for nuget registry, so the auth level validation provide the Actions User info even if you authenticate via the nuget api header.

  • Actions User cannot use packages with this change, it fails access package access validation later on.

@ChristopherHX ChristopherHX mentioned this pull request Feb 8, 2026
Merged
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Made some changes to reduce changed lines, now the diff looks simpler

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Oops, CI fails

@ChristopherHX
Copy link
Copy Markdown
Contributor Author

ChristopherHX commented Feb 8, 2026 •
edited
Loading

Hmm, my version at least has a passing TestPackageMaven for me locally, need to look at your change.

EDIT after pulling test is red.

@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Hmm, my version at least has a passing TestPackageMaven for me locally, need to look at your change.

EDIT after pulling test is red.

I will fix 🙏

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 8, 2026 14:14
@wxiaoguang wxiaoguang merged commit f65df2a into go-gitea:main Feb 8, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 8, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 9, 2026
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f55a8b3 
* giteaofficial/main:
  Refactor merge conan and container auth preserve actions taskID (go-gitea#36560)
  Fix assignee sidebar links and empty placeholder after go-gitea#32465 refactor (go-gitea#36559)
  Fix various version parsing problems (go-gitea#36553)
  Fix highlight diff result (go-gitea#36539)
  Refactor Nuget Auth to reuse Basic Auth Token Validation (go-gitea#36558)
  Update go dependencies (go-gitea#36548)
  Prevent navigation keys from triggering actions during IME composition (go-gitea#36540)
  Fix various mermaid bugs (go-gitea#36547)
  Add `elk` layout support to mermaid (go-gitea#36486)
  Allow configuring default PR base branch (fixes go-gitea#36412) (go-gitea#36425)
  [skip ci] Updated translations via Crowdin
  Color command/error logs in Actions log (go-gitea#36538)
  Add paging headers (go-gitea#36521)
  Fix issues filter dropdown showing empty label scope section (go-gitea#36535)
  [SECURITY] fix: Adjust the toolchain version (go-gitea#36537)
  Hide `add-matcher` and `remove-matcher` from actions job logs (go-gitea#36520)
  Improve timeline entries for WIP prefix changes in pull requests (go-gitea#36518)
Sirherobrine23 pushed a commit to Sirherobrine23/gitea that referenced this pull request Mar 4, 2026
@ChristopherHX @wxiaoguang @Sirherobrine23
Refactor Nuget Auth to reuse Basic Auth Token Validation (go-gitea#36558
c74d02a 
)

* Implicitly handle Actions Task Token for Nuget Api Keys
* Support same tokens as Basic Auth in Nuget Api Key Header

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristopherHX @wxiaoguang @delvh @GiteaBot